feat(platform): Support multiple credentials inputs on blocks #8932
+203
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `credentials` inputs - Add `credentials_provider` and `credentials_types` to field schema from `CredentialsMetaInput` instead of `CredentialsField` - Remove `provider` and `supported_credential_types` params from `CredentialsField` and all its usages - Add `credentials` schema validation logic to `CredentialsMetaInput`, which is called from `BlockSchema.__pydantic_init_subclass__`
- Add missing providers to `ProviderName`
- Replace string literals for provider names with `ProviderName.{PROVIDER}` on blocks and in `CredentialsMetaInput`, `BlockWebhookConfig`, `*OAuthHandler`
- docs: Update instructions for blocks with authentication
github-actions
bot
added
documentation
✅ Deploy Preview for auto-gpt-docs-dev canceled.
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
Pwuts
requested review from
ntindle,
Swiftyos,
aarushik93 and
kcze
and removed request for
a team and
Swiftyos
…support-multiple-provider-credentials-inputs
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
github-actions
bot
added
the
conflicts
…support-multiple-provider-credentials-inputs
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
github-actions
bot
removed
the
conflicts
|
@aarushik93 could you branch from this PR and see if it works for you? I currently have no blocks to test it on. |
github-actions
bot
added
the
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
…redentials-inputs
github-actions
bot
removed
the
conflicts
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
kcze
reviewed
Dec 13, 2024
| @@ -256,7 +257,8 @@ export function CustomNode({ | |||
| side="left" | |||
| /> | |||
| ) : ( | |||
| propKey != "credentials" && ( | |||
| propKey != "credentials" && | |||
There was a problem hiding this comment.
nit
Suggested change
| propKey != "credentials" && | |
| propKey !== "credentials" && |
| extra_exec_kwargs[field_name] = block.test_credentials | ||
| elif credentials_input_fields and block.test_credentials: | ||
| if not isinstance(block.test_credentials, dict): | ||
| log.warning(f"Block {block.name} has no usable test credentials") |
There was a problem hiding this comment.
Why not raise? It's a test, shouldn't it fail?
| f"Node #{node.id} referenced non-existent " | ||
| f"credentials #{creds_meta['id']}" | ||
| if ( | ||
| # Webhook-triggered blocks are only allowed to have 1 credentials input |
There was a problem hiding this comment.
Why? Won't we end up like now where we need multiple?
aarushik93
approved these changes
Dec 17, 2024
github-actions
bot
added
the
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CredentialsFieldusage + useProviderNameglobally #8725Changes 🏗️
feat(platform): Support multiple credentials inputs on blocks
Update docs with info on multi credentials support
Checklist 📋
For code changes: