Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): add block tests #8804

Merged
merged 26 commits into from
Dec 3, 2024
Merged

feat(frontend): add block tests #8804

merged 26 commits into from
Dec 3, 2024

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Nov 27, 2024 •
edited
Loading

We want to be able to automatically test agent running creation and building via the build page

Changes 🏗️

  • updates many UI elements to have new data ids
  • adds page for build
  • adds spec for build

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Run the UI Tests!

@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/l labels Nov 27, 2024
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@ntindle
Merge branch 'ntindle/open-2060-add-a-utility-that-enables-all-tests-…
6894b33 
…other-than-auth-to-use' into ntindle/open-2093-integration-test-build-an-agent-with-a-few-blocks-including
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Nov 27, 2024
Base automatically changed from ntindle/open-2060-add-a-utility-that-enables-all-tests-other-than-auth-to-use to dev November 27, 2024 09:44
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 27, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 27, 2024 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit 34651ff
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/674f2384d7af4a00084d4f0a

@github-actions github-actions bot added size/xl and removed size/l labels Nov 27, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 27, 2024 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 34651ff
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/674f23845968360008c7cf18

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot added size/l and removed size/xl labels Dec 2, 2024
@github-actions github-actions bot added size/xl and removed size/l labels Dec 3, 2024
@ntindle ntindle marked this pull request as ready for review December 3, 2024 00:16
@ntindle ntindle requested a review from a team as a code owner December 3, 2024 00:16
@ntindle ntindle requested review from Swiftyos and Bentlybro and removed request for a team December 3, 2024 00:16
@qodo-merge-pro Qodo Merge Pro
Copy link

qodo-merge-pro bot commented Dec 3, 2024

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Test Reliability
The test timeout is increased by 10x with a comment "sorry future me". This could indicate potential performance or reliability issues that should be investigated rather than worked around with increased timeouts.

Code Smell
The getBlockOutputs() method is not implemented and just throws an error. This could cause issues if called by tests.

@ntindle
ref: remove dead and unuseful code
77ffe02
@ntindle
Merge branch 'ntindle/open-2093-integration-test-build-an-agent-with-…
cc7ef5a 
…a-few-blocks-including' of https://github.com/Significant-Gravitas/AutoGPT into ntindle/open-2093-integration-test-build-an-agent-with-a-few-blocks-including
@Bentlybro
Copy link
Member

Bentlybro commented Dec 3, 2024 •
edited
Loading

i have tested the login and block tests but some timeout's because the backend can be slow to load, I feel expanding the default timeout may help? did you have this issue?

Timeline.1.mp4

@ntindle
Copy link
Member Author

ntindle commented Dec 3, 2024

Those ones aren't ever going to hit their time out. They missed the window for grabbing the identifier. Retrying for now is the best bet until Craig's changes land or we will end up adding ids all over the place and giving him a hundred merge conflicts

@ntindle ntindle added this pull request to the merge queue Dec 3, 2024
Merged via the queue into dev with commit 89011aa Dec 3, 2024
19 checks passed
@ntindle ntindle deleted the ntindle/open-2093-integration-test-build-an-agent-with-a-few-blocks-including branch December 3, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bentlybro Bentlybro Bentlybro approved these changes

@Swiftyos Swiftyos Awaiting requested review from Swiftyos Swiftyos is a code owner automatically assigned from Significant-Gravitas/maintainers

Assignees
No one assigned
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 2 size/xl
Projects
Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntindle @Bentlybro