Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): advanced-toggle-default #8802

Conversation

Abhi1992002
Copy link
Contributor

@Abhi1992002 Abhi1992002 commented Nov 27, 2024

I don't think so that this is a frontend issue [might be wrong] , because if we are not classifying that a particular input is advanced = true/false. Then we automatically get advanced = True.

Screenshot 2024-11-27 at 10 36 59 AM

@Abhi1992002 Abhi1992002 requested a review from a team as a code owner November 27, 2024 05:31
@Abhi1992002 Abhi1992002 requested review from Torantulino and Bentlybro and removed request for a team November 27, 2024 05:31
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit df65229
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/6746aea3524b6e0008ff5241

@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/s labels Nov 27, 2024
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit df65229
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6746aea30fa4140008a51cb7
😎 Deploy Preview https://deploy-preview-8802--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Abhi1992002 Abhi1992002 changed the title fix-advanced-toggle-default fix(platform) : advanced-toggle-default Nov 27, 2024
@Pwuts Pwuts changed the title fix(platform) : advanced-toggle-default fix(frontend): dvanced-toggle-default Nov 27, 2024
@Pwuts Pwuts changed the title fix(frontend): dvanced-toggle-default fix(frontend): advanced-toggle-default Nov 27, 2024
@Pwuts
Copy link
Member

Pwuts commented Nov 27, 2024

If it works for other blocks, then could you check why the toggle isn't working on the GithubPullRequestTriggerBlock?

@Abhi1992002
Copy link
Contributor Author

Abhi1992002 commented Nov 27, 2024

If it works for other blocks, then could you check why the toggle isn't working on the GithubPullRequestTriggerBlock?

To make it work, we need to explicitly set advanced = False in both the event and the trigger.

similar to this

 value: Any = SchemaField(
            default=None,
            description="The value for the new entry.",
            placeholder="new_value",
            advanced=False,
        )
        
entries: dict[Any, Any] = SchemaField(
            default={},
            description="The entries to add to the dictionary. This is the batch version of the `key` and `value` fields.",
            advanced=True,
        )

@aarushik93 aarushik93 added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@aarushik93 aarushik93 added this pull request to the merge queue Dec 3, 2024
Merged via the queue into Significant-Gravitas:dev with commit 43bd5c8 Dec 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants