Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform): Include all agent versions in Runs in Monitor #8752

Conversation

kcze
Copy link
Contributor

@kcze kcze commented Nov 25, 2024

The graph version is bumped on each save. While the agent version is changed, the past execution history is gone because the monitor page only shows the latest version's execution history.

Changes 🏗️

  • Add get_executions on the backend that returns all executions of all graphs for a user
  • Display all executions (for all versions) for graphs in Monitor
  • Rename ts mirror type ExecutionMeta to GraphExecution for consistency with the backend
  • Remove redundant FlowRun type on the frontend and use GraphExecution instead
  • Round execution duration text in Monitor to one decimal place

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@kcze kcze requested a review from a team as a code owner November 25, 2024 10:49
@kcze kcze requested review from ntindle and Torantulino and removed request for a team November 25, 2024 10:49
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Nov 25, 2024
@kcze kcze requested review from Pwuts, aarushik93 and majdyz and removed request for ntindle and Torantulino November 25, 2024 10:50
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit af61af8
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6758c3de86915e00081d349a

Copy link
Member

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fix but big UX improvement. Thanks for picking this up :)

Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 25, 2024
@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Dec 10, 2024
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit af61af8
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/6758c3defabc7600089c912a

@github-actions github-actions bot added size/l and removed size/m labels Dec 10, 2024
@kcze kcze requested review from majdyz and Pwuts December 10, 2024 15:20
Copy link
Contributor

@majdyz majdyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! this is really cool!

@majdyz majdyz enabled auto-merge December 11, 2024 01:27
@majdyz majdyz added this pull request to the merge queue Dec 11, 2024
Merged via the queue into dev with commit 6307ca1 Dec 11, 2024
21 checks passed
@majdyz majdyz deleted the kpczerwinski/open-1976-monitor-page-only-show-execution-on-the-latest-graph-version branch December 11, 2024 01:59
github-merge-queue bot pushed a commit that referenced this pull request Dec 11, 2024
…d Graph Execution functions (#8939)

This is a follow-up of
#8752

There are several APIs and functions related to graph execution that are
unused now.
There is also confusion about the name of `GraphExecution` that exists
in graph.py & execution.py.

### Changes 🏗️

* Renamed `GraphExecution` in `execution.py` to `GraphExecutionEntry`,
this is only used as a queue entry for execution.
* Removed unused `get_graph_execution` & `list_executions` in
`execution.py`.
* Removed `with_run` option on `get_graph` function in `graph.py`.
* Removed `GraphMetaWithRuns`
* Removed exposed functions only for testing.
* Removed `executions` fields in Graph model.

### Checklist 📋

#### For code changes:
- [ ] I have clearly listed my changes in the PR description
- [ ] I have made a test plan
- [ ] I have tested my changes according to the test plan:
  <!-- Put your test plan here: -->
  - [ ] ...

<details>
  <summary>Example test plan</summary>
  
  - [ ] Create from scratch and execute an agent with at least 3 blocks
- [ ] Import an agent from file upload, and confirm it executes
correctly
  - [ ] Upload agent to marketplace
- [ ] Import an agent from marketplace and confirm it executes correctly
  - [ ] Edit an agent from monitor, and confirm it executes correctly
</details>

#### For configuration changes:
- [ ] `.env.example` is updated or already compatible with my changes
- [ ] `docker-compose.yml` is updated or already compatible with my
changes
- [ ] I have included a list of my configuration changes in the PR
description (under **Changes**)

<details>
  <summary>Examples of configuration changes</summary>

  - Changing ports
  - Adding new services that need to communicate with each other
  - Secrets or environment variable changes
  - New or infrastructure changes such as databases
</details>

---------

Co-authored-by: Krzysztof Czerwinski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end size/l
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants