Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): Resolve Pydantic warning about missing secrets_dir #8692

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix(backend): Resolve Pydantic warning about missing secrets_dir #8692

merged 2 commits into from
Nov 18, 2024

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Nov 18, 2024 •
edited
Loading

Changes 🏗️

  • Remove secrets_dir and other references to get_secrets_path()
  • Remove unused get_config_path()

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Run backend, see if warnings appear
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@Pwuts Pwuts requested a review from a team as a code owner November 18, 2024 12:31
@Pwuts Pwuts requested review from Bentlybro and kcze and removed request for a team November 18, 2024 12:31
@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/m labels Nov 18, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 18, 2024 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit eb603ae
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/673b34ce4c8f6f00085b8e77

@Pwuts Pwuts linked an issue Nov 18, 2024 that may be closed by this pull request
Fix pydantic_settings.UserWarning on backend.util.settings.Secrets #8689
Closed
@Pwuts Pwuts enabled auto-merge (squash) November 18, 2024 12:37
@Pwuts Pwuts requested a review from ntindle November 18, 2024 12:41
@Pwuts Pwuts requested a review from Swiftyos November 18, 2024 12:41
@Pwuts Pwuts merged commit e840106 into dev Nov 18, 2024
15 checks passed
@Pwuts Pwuts deleted the reinier/open-2055-fix-pydantic_settingsuserwarning-on branch November 18, 2024 12:41
@Pwuts Pwuts removed request for Bentlybro and kcze November 18, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarushik93 aarushik93 aarushik93 approved these changes

@ntindle ntindle Awaiting requested review from ntindle

@Swiftyos Swiftyos Awaiting requested review from Swiftyos

Assignees
No one assigned
Labels
platform/backend AutoGPT Platform - Back end size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix pydantic_settings.UserWarning on backend.util.settings.Secrets
2 participants
@Pwuts @aarushik93