Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): avoid displaying long description text for block #8688

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Nov 18, 2024

image

Changes πŸ—οΈ

Avoid displaying long description text for block

Checklist πŸ“‹

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@majdyz majdyz requested a review from a team as a code owner November 18, 2024 12:14
Copy link

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 πŸ”΅βšͺβšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Edge Case
The description truncation logic should handle cases where description is undefined/null to avoid potential runtime errors

@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/s labels Nov 18, 2024
Copy link

netlify bot commented Nov 18, 2024

βœ… Deploy Preview for auto-gpt-docs ready!

Name Link
πŸ”¨ Latest commit 9ae8391
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/673b2f954b97080008a14872
😎 Deploy Preview https://deploy-preview-8688--auto-gpt-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 18, 2024

βœ… Deploy Preview for auto-gpt-docs canceled.

Name Link
πŸ”¨ Latest commit b59554b
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/673b3daef65f48000844c0c0

@Torantulino Torantulino enabled auto-merge (squash) November 18, 2024 12:57
@Torantulino Torantulino disabled auto-merge November 18, 2024 13:05
@Torantulino Torantulino enabled auto-merge (squash) November 18, 2024 13:10
@Torantulino Torantulino merged commit 402789d into dev Nov 18, 2024
14 checks passed
@Torantulino Torantulino deleted the zamilmajdy/fix-long-description-block branch November 18, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 1 size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants