Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): Remove migrate and encrypt function #8646

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

aarushik93
Copy link
Contributor

@aarushik93 aarushik93 commented Nov 13, 2024

Our understanding of the code is as follows:

if we have 100 users, we'll do 100 SQL separate requests. Can we avoid doing this on each run or remove this altogether?

the migration part was meant to be for solving the issue we had 2 weeks ago only, not permanently in the codebase.

Confirmed with @ntindle it's okay to remove.

See discussion.

Changes 🏗️

Removed the migrate_and_encrypt_user_integrations function and it's relevant reference.

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@aarushik93 aarushik93 requested a review from a team as a code owner November 13, 2024 21:53
@aarushik93 aarushik93 requested review from Bentlybro, majdyz and ntindle and removed request for a team November 13, 2024 21:53
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Data Migration
Removal of migration function could impact existing users who haven't had their integration credentials migrated yet. Verify that all users have already been migrated before removing this code.

@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/m labels Nov 13, 2024
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 5600b69
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/673530b76db8720008b8e039

@aarushik93 aarushik93 enabled auto-merge (squash) November 13, 2024 23:05
@aarushik93 aarushik93 merged commit c707ee9 into dev Nov 13, 2024
15 checks passed
@aarushik93 aarushik93 deleted the aarushikansal/remove-migrate-encrypt branch November 13, 2024 23:09
Pwuts added a commit that referenced this pull request Nov 14, 2024
Pwuts added a commit that referenced this pull request Nov 14, 2024
Reverts c707ee9 (#8646)

The problem analysis that led to #8646 contained some errors, so the migration removed in the PR doesn't seem to have been the cause of the problem we were hunting. Also, this migration is an essential part of the security improvement that we made 2 weeks ago.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants