Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blocks/jina): Add default credentials for Jina #8603

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

aarushik93
Copy link
Contributor

We want to provide jina by default on our platform

Changes πŸ—οΈ

Added Jina credentials to all the default settings in store.py.
Added a jina cost filter in credit.py

Checklist πŸ“‹

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@aarushik93 aarushik93 requested a review from a team as a code owner November 10, 2024 17:14
@aarushik93 aarushik93 requested review from Bentlybro and kcze and removed request for a team November 10, 2024 17:14
Copy link

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 πŸ”΅πŸ”΅βšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β Security concerns

API Key Exposure:
The PR adds handling for a new Jina API key. While the key itself is stored securely using SecretStr, verify that the key is properly protected in all contexts where it's used and that it's not accidentally logged or exposed in error messages.

⚑ Recommended focus areas for review

Cost Filter Change
The SearchTheWebBlock cost filter was changed from a simple cost amount to include Jina credentials. This change should be validated to ensure it doesn't break existing functionality or billing.

@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/m labels Nov 10, 2024
Copy link

netlify bot commented Nov 10, 2024

βœ… Deploy Preview for auto-gpt-docs canceled.

Name Link
πŸ”¨ Latest commit 975f43d
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6730ea0ed5c12c0008d666c6

@Torantulino Torantulino enabled auto-merge (squash) November 10, 2024 17:18
@Torantulino Torantulino merged commit e6e4737 into dev Nov 10, 2024
15 checks passed
@Torantulino Torantulino deleted the aarushikansal/add-jina-default branch November 10, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants