-
Notifications
You must be signed in to change notification settings - Fork 44.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): Fix iteration and timer block #8596
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
289f829
to
57ddeb4
Compare
✅ Deploy Preview for auto-gpt-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the changes here, but we need to figure out migration routes for these type of changes in general. Can you check the marketplace for these being used? if not problematic, feel free to merge
…milmajdy/fix-iteration-and-timer-block
…:Significant-Gravitas/AutoGPT into zamilmajdy/fix-iteration-and-timer-block
@ntindle good point, I don't see it being used at all in the marketplace, but I can see some historical graphs using it. So I reverted the breaking change. |
Is this compatible with loading graphs that have the old version of the block in it now? Nick is right that we need to not break blocks until we implement block versioning. |
The added input is not mandatory, so it's not going to break the old block |
The only case that it might break is if there is a graph that uses |
Superseded by: #8713 |
Pull request was closed
Background
Improvement on the Step Through Items & Timer block.
Changes 🏗️
Testing 🔍
Note
Only for the new autogpt platform, currently in autogpt_platform/
Configuration Changes 📝
Note
Only for the new autogpt platform, currently in autogpt_platform/
If you're making configuration or infrastructure changes, please remember to check you've updated the related infrastructure code in the autogpt_platform/infra folder.
Examples of such changes might include: