Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(platform): Update pipelines to run from infra repo #8595

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

aarushik93
Copy link
Contributor

Background

We made the decision to move most things to a private repo, related to cloud deployment. Running this pipeline through the private repo then

Changes 🏗️

Removed build and deploy steps to instead triggger a workflow in infra repo

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

Configuration Changes 📝

Note

Only for the new autogpt platform, currently in autogpt_platform/

If you're making configuration or infrastructure changes, please remember to check you've updated the related infrastructure code in the autogpt_platform/infra folder.

Examples of such changes might include:

  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/l labels Nov 8, 2024
@aarushik93 aarushik93 marked this pull request as ready for review November 8, 2024 04:39
@aarushik93 aarushik93 requested a review from a team as a code owner November 8, 2024 04:39
@aarushik93 aarushik93 merged commit c0f77c8 into dev Nov 8, 2024
9 checks passed
@aarushik93 aarushik93 deleted the aarushikansal/deploy-from-infra branch November 8, 2024 04:40
Copy link

qodo-merge-pro bot commented Nov 8, 2024

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 Security concerns

Repository token exposure:
The PR introduces the use of repository dispatch tokens in both the production and development workflows. While this is a common practice for triggering workflows in other repositories, it's crucial to ensure that these tokens (DEPLOY_TOKEN) have the minimum required permissions and are properly secured. Exposing tokens with excessive permissions could potentially lead to unauthorized access or actions in the target repository.

⚡ Recommended focus areas for review

Security Concern
The workflow is using a repository dispatch token. Ensure that this token has the minimum required permissions and is properly secured.

Security Concern
Similar to the production workflow, this development workflow is using a repository dispatch token. Verify that this token has the minimum required permissions and is properly secured.

Workflow Modification
The build, push, and deploy steps have been removed and replaced with a trigger step. Ensure that the new workflow in the infrastructure repository correctly handles these operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant