Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blocks): Pinecone blocks #8535

Merged
merged 15 commits into from
Nov 8, 2024
Merged

feat(blocks): Pinecone blocks #8535

merged 15 commits into from
Nov 8, 2024

Conversation

aarushik93
Copy link
Contributor

@aarushik93 aarushik93 commented Nov 4, 2024

Background

Pinecone query output needed enhancements to be more usable.
Needed the ability to insert

Screen.Recording.2024-11-07.at.5.40.26.PM.mov
Screen.Recording.2024-11-07.at.5.42.43.PM.mov

Changes 🏗

Updated Pinecone output to be the matches, and combined text
Added a Pinecone Insert block

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

Configuration Changes 📝

Note

Only for the new autogpt platform, currently in autogpt_platform/

If you're making configuration or infrastructure changes, please remember to check you've updated the related infrastructure code in the autogpt_platform/infra folder.

Examples of such changes might include:

  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@aarushik93 aarushik93 requested a review from a team as a code owner November 4, 2024 06:20
@aarushik93 aarushik93 requested review from kcze and majdyz and removed request for a team November 4, 2024 06:20
@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end platform/blocks labels Nov 4, 2024
Copy link

qodo-merge-pro bot commented Nov 4, 2024

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 Security concerns

Sensitive information exposure:
The code in 'autogpt_platform/backend/backend/blocks/jina/search.py' includes an API key in the request headers. While it's using a secret value, it's important to ensure that this key is properly protected and not logged or exposed in any way. Additionally, make sure that the HTTPS protocol is used for the Jina search URL to prevent potential man-in-the-middle attacks.

⚡ Recommended focus areas for review

Error Handling
The block raises exceptions without proper error handling or logging. Consider implementing a try-except block to catch and handle potential errors gracefully.

Code Duplication
There's potential for code duplication in the Pinecone client initialization. Consider extracting the client creation into a separate method to improve maintainability.

Error Handling
The error handling in the PineconeInsertBlock could be improved. Consider adding more specific exception handling and providing more detailed error messages.

ntindle
ntindle previously approved these changes Nov 4, 2024
@majdyz majdyz removed their request for review November 5, 2024 08:46
@aarushik93 aarushik93 requested a review from ntindle November 7, 2024 00:51
@aarushik93 aarushik93 enabled auto-merge (squash) November 7, 2024 17:27
@aarushik93
Copy link
Contributor Author

Split this out #8583

@aarushik93 aarushik93 changed the title feat(blocks): Update Jina & Pinecone blocks feat(blocks): Pinecone blocks Nov 7, 2024
@aarushik93 aarushik93 disabled auto-merge November 8, 2024 03:30
@aarushik93 aarushik93 enabled auto-merge (squash) November 8, 2024 03:30
@aarushik93 aarushik93 merged commit f719c7e into dev Nov 8, 2024
11 checks passed
@aarushik93 aarushik93 deleted the aarushikansal/block-updates branch November 8, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants