Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(block): Add AI video generator block with Fal txt 2 vid #8528

Merged

Conversation

Torantulino
Copy link
Member

@Torantulino Torantulino commented Nov 3, 2024

Background

Implements an AI Video Generator Block for text to image models hosted on Fal

image

Copy link
Contributor

github-actions bot commented Nov 3, 2024

This PR targets the master branch but does not come from dev or a hotfix/* branch.

Automatically setting the base branch to dev.

@github-actions github-actions bot changed the base branch from master to dev November 3, 2024 18:08
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end platform/blocks size/l labels Nov 3, 2024
Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit c6ae4a2
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6749b8ada3b786000850790e

@Torantulino Torantulino changed the title feat(block): Add AI Video Generator block with Mochi 1 feat(block): Add AI video generator block with Mochi 1 Nov 27, 2024
Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit c6ae4a2
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/6749b8adce500e000802af1e

@aarushik93 aarushik93 marked this pull request as ready for review November 29, 2024 12:34
@aarushik93 aarushik93 requested a review from a team as a code owner November 29, 2024 12:34
@aarushik93 aarushik93 requested review from aarushik93 and majdyz and removed request for a team November 29, 2024 12:34
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 PR contains tests
🔒 Security concerns

API Key Exposure:
The code handles sensitive FAL API keys. While the keys are stored using SecretStr, care should be taken to ensure they are not exposed in logs or error messages. The error handling at lines 188-199 could potentially leak API key information in the error message if the API response contains sensitive data.

⚡ Recommended focus areas for review

Error Handling
The error handling in the video generation process could be improved. The code catches general exceptions and converts them to error messages, but may not handle all edge cases like network timeouts or API rate limits appropriately.

Resource Management
The httpx client is created for each request without using a context manager or proper cleanup. Consider using 'with httpx.Client() as client' pattern for better resource management.

Performance Concern
The polling mechanism uses exponential backoff but could benefit from more sophisticated retry logic and connection pooling for better performance under load.

@aarushik93 aarushik93 enabled auto-merge November 29, 2024 12:34
@aarushik93 aarushik93 changed the title feat(block): Add AI video generator block with Mochi 1 feat(block): Add AI video generator block with Fal txt 2 vid Nov 29, 2024
@aarushik93 aarushik93 added this pull request to the merge queue Nov 29, 2024
Merged via the queue into dev with commit 4aa5f53 Nov 29, 2024
21 checks passed
@aarushik93 aarushik93 deleted the toran/open-2001-implement-ai-video-generator-block-with-mochi-1 branch November 29, 2024 13:18
aarushik93 added a commit that referenced this pull request Dec 1, 2024
### Background

Implements an AI Video Generator Block for text to image models hosted
on Fal


![image](https://github.com/user-attachments/assets/9cb70015-4174-4419-8c1a-4144f324442f)

---------

Co-authored-by: Aarushi <[email protected]>
Co-authored-by: Aarushi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants