Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): Make button text non-selectable in the Builder #8520

Closed
wants to merge 2 commits into from
Closed

feat(frontend): Make button text non-selectable in the Builder #8520

wants to merge 2 commits into from
+3 −3

Conversation

kcze
Copy link
Contributor

@kcze kcze commented Nov 1, 2024

Background

Navbar and bottom buttons in the Builder can be selected accidentally or by using ctrl+A.

Changes 🏗️

  • Make button text in Builder non-selectable

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@kcze kcze requested a review from a team as a code owner November 1, 2024 12:42
@kcze kcze requested review from Swiftyos and Pwuts and removed request for a team November 1, 2024 12:42
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/s labels Nov 1, 2024
@kcze kcze requested review from Torantulino, aarushik93 and majdyz and removed request for Swiftyos and Pwuts November 1, 2024 12:42
@majdyz
Copy link
Contributor

majdyz commented Nov 5, 2024

Might require running npm run format

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@kcze
Copy link
Contributor Author

kcze commented Nov 14, 2024

Done here: #8534

@kcze kcze closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majdyz majdyz majdyz approved these changes

@Torantulino Torantulino Awaiting requested review from Torantulino

@aarushik93 aarushik93 Awaiting requested review from aarushik93

Assignees
No one assigned
Labels
conflicts Automatically applied to PRs with merge conflicts platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kcze @majdyz