Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): Show Agent Output on Monitor page #8501

Merged
merged 12 commits into from
Nov 20, 2024
Merged

feat(frontend): Show Agent Output on Monitor page #8501

merged 12 commits into from
Nov 20, 2024

Conversation

kcze
Copy link
Contributor

@kcze kcze commented Oct 30, 2024

Background

There's no way to see Agent Outputs in Monitor, there are only on the Build page when running an agent.

Changes 🏗️

  • Add View Outputs button to Agent runs in Monitor
  • Reuse Sheet component used on the Build page to show results of Agent Output nodes

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@kcze kcze requested a review from a team as a code owner October 30, 2024 06:26
@kcze kcze requested review from ntindle, Bentlybro, Torantulino, aarushik93 and majdyz and removed request for a team and ntindle October 30, 2024 06:26
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/l labels Oct 30, 2024
@Torantulino Torantulino mentioned this pull request Nov 13, 2024
Merged
@netlify Netlify
Copy link

netlify bot commented Nov 14, 2024 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 6fa6d28
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/673df8956664980008648d47

@kcze kcze requested a review from majdyz November 15, 2024 06:17
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Nov 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Nov 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@kcze kcze requested a review from majdyz November 20, 2024 09:09
majdyz
majdyz approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@majdyz majdyz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding e623d16 to cleanup the hardcoded ID, since now we have two places where this is needed. Let me know if this is okay.

Otherwise looks good! Thanks for adding this!

By the way, why aren't we showing the agent input? It's equally useful.

@Torantulino
Copy link
Member

I'm adding e623d16 to cleanup the hardcoded ID, since now we have two places where this is needed. Let me know if this is okay.

Otherwise looks good! Thanks for adding this!

By the way, why aren't we showing the agent input? It's equally useful.

The new library page does do this so I don't want to spend too much time on work that's going to be overwritten, but yeah it would also be very easy to add that button, good point!

@Torantulino Torantulino enabled auto-merge (squash) November 20, 2024 14:56
@Torantulino Torantulino merged commit cf43248 into dev Nov 20, 2024
15 checks passed
@Torantulino Torantulino deleted the kpczerwinski/open-1989-show-agent-output-in-monitor-page branch November 20, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majdyz majdyz majdyz approved these changes

@Bentlybro Bentlybro Awaiting requested review from Bentlybro Bentlybro is a code owner automatically assigned from Significant-Gravitas/maintainers

@Torantulino Torantulino Awaiting requested review from Torantulino

@aarushik93 aarushik93 Awaiting requested review from aarushik93

Assignees
No one assigned
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kcze @Torantulino @majdyz @aarushik93