Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(infra): Update variable names #8447

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

aarushik93
Copy link
Contributor

Background

Updating prod variable names for pools and service accounts.

Changes πŸ—οΈ

Update the service account name and desc, and change project number

Testing πŸ”

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

Configuration Changes πŸ“

Note

Only for the new autogpt platform, currently in autogpt_platform/

If you're making configuration or infrastructure changes, please remember to check you've updated the related infrastructure code in the autogpt_platform/infra folder.

Examples of such changes might include:

  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@aarushik93 aarushik93 requested a review from a team as a code owner October 24, 2024 19:06
@aarushik93 aarushik93 merged commit 6d812ac into dev Oct 24, 2024
6 checks passed
@aarushik93 aarushik93 deleted the aarushikansal/update-service-account branch October 24, 2024 19:06
@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end and removed Review effort [1-5]: 2 labels Oct 24, 2024
Copy link

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 πŸ”΅πŸ”΅βšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Configuration Change
The PR updates the project number in the workload identity pool configuration. Verify if this change is intentional and corresponds to the correct project.

Resource Naming
The workload identity pool name has been changed from "dev-pool" to "prod-pool". Ensure this change is intentional and consistent with the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end size/m
Projects
Status: βœ… Done
Development

Successfully merging this pull request may close these issues.

1 participant