Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): Fix containerized connection issues with DB Manager #8412

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

aarushik93
Copy link
Contributor

Background

In this PR #8283, a change was added so that the rest service also communicates with the DB manager, which was not previously the case.
In docker and k8s environments the host is handled by their respective environments, so the DB host needs to be specified as it's not on the same host.

Changes 🏗️

Added DBMANAGER_HOST to docker compose and server values.dev.yaml and values.prod.yaml

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@aarushik93 aarushik93 requested review from a team as code owners October 23, 2024 14:11
@aarushik93 aarushik93 requested review from kcze and majdyz and removed request for a team October 23, 2024 14:11
@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/s labels Oct 23, 2024
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Configuration Update
Verify that the added DBMANAGER_HOST environment variable is correctly set to 'executor' and that this value is appropriate for the containerized environment.

Environment Configuration
Ensure that the DBMANAGER_HOST value is correctly set to "autogpt-server-executor.dev-agpt.svc.cluster.local" and that this hostname is valid in the development environment.

Production Configuration
Confirm that the DBMANAGER_HOST value "autogpt-server-executor.prod-agpt.svc.cluster.local" is correct for the production environment and that it aligns with the actual infrastructure setup.

@aarushik93 aarushik93 enabled auto-merge (squash) October 23, 2024 14:13
@aarushik93 aarushik93 merged commit e499509 into dev Oct 23, 2024
6 checks passed
@aarushik93 aarushik93 deleted the aarushikansal/fix-platform-connections branch October 23, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants