You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes enhance the placement algorithm for new blocks, ensuring they don’t overlap with existing ones despite varying dimensions. They dynamically adjust block positions and the viewing canvas to optimize layout and visibility.
Changes 🏗️
Added findNodeDimensions function to calculate the dimensions of all nodes.
Introduced findNewlyAddedBlockCoordinates to determine the coordinates for newly added blocks.
Implemented rectanglesOverlap to ensure that two nodes do not overlap.
Enhanced functionality to zoom into a node immediately after it is added.
Complex Logic The new block positioning logic is complex and may need thorough testing to ensure it works correctly in all scenarios.
Performance Concern The findNewlyAddedBlockCoordinates function uses nested loops and multiple collision checks, which might impact performance for large numbers of nodes.
State Management The nodeDimensions state is updated on every render, which could lead to unnecessary re-renders and potential performance issues.
The reason will be displayed to describe this comment to others. Learn more.
This is really good! Thank you so much for this 👍
I left a few very minor code styling nits if you don't mind addressing it.
Otherwise, I'm happy to merge this PR.
majdyz
changed the title
Improve block positioning logic to handle collisions and dynamic dime…
feat(frontend): Improve added block positioning logic to handle collisions and dynamic dimensions size
Oct 23, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abhi1992002
requested review from
aarushik93 and
majdyz
and removed request for
a team
github-actions
bot
added
platform/frontend
majdyz
changed the title
Background #8268
These changes enhance the placement algorithm for new blocks, ensuring they don’t overlap with existing ones despite varying dimensions. They dynamically adjust block positions and the viewing canvas to optimize layout and visibility.
Changes 🏗️
block.position.mp4