Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): Update deletion of secret values to not do it in place #8284

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

aarushik93
Copy link
Contributor

Background

The delete from the review was added here: #8281 (comment). This should not have been an inplace operation.

Changes πŸ—οΈ

Made it so we track the keys to delete

Testing πŸ”

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@aarushik93 aarushik93 requested a review from a team as a code owner October 8, 2024 21:35
@aarushik93 aarushik93 requested review from Torantulino and kcze and removed request for a team October 8, 2024 21:35
@github-actions github-actions bot added the platform/backend AutoGPT Platform - Back end label Oct 8, 2024
Copy link

qodo-merge-pro bot commented Oct 8, 2024

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 πŸ”΅πŸ”΅βšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Potential Data Loss
The new implementation skips sensitive key-value pairs instead of replacing them with a placeholder. This might lead to unexpected behavior if the calling code assumes these keys are present.

Recursive Function Call
The function _hide_credentials_in_input calls itself recursively for nested dictionaries. While this works, it might benefit from a comment explaining the recursive nature for better maintainability.

@github-actions github-actions bot added the size/m label Oct 8, 2024
Copy link

netlify bot commented Oct 8, 2024

βœ… Deploy Preview for auto-gpt-docs canceled.

Name Link
πŸ”¨ Latest commit f5ac52f
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6705a5a427ba2e00089c757c

@aarushik93 aarushik93 enabled auto-merge (squash) October 8, 2024 21:37
@aarushik93 aarushik93 merged commit e37744b into master Oct 8, 2024
14 checks passed
@aarushik93 aarushik93 deleted the aarushikansal/hotfix-del-inplace-error branch October 8, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: βœ… Done
Development

Successfully merging this pull request may close these issues.

2 participants