Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON string escaping issue #72

Conversation

PhilipAD
Copy link
Contributor

@PhilipAD PhilipAD commented Apr 3, 2023

Fixes an issue where double quotes were not being escaped in JSON strings, causing parse errors.

Fixes an issue where double quotes were not being escaped in JSON strings, causing parse errors.
rmcsharry
rmcsharry previously approved these changes Apr 3, 2023
Copy link

@rmcsharry rmcsharry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice quick fix! 👍

fix by converting to valid null value for JSON
consistent escaping
Copy link
Contributor

@nponeccop nponeccop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be better documented. The current problem happens because of GPT behavior and may not be needed anymore when OpenAI improves the model or when someone improves the prompt. The PR is a clear improvement though.

@nponeccop
Copy link
Contributor

Resolve the conflicts.

@nponeccop nponeccop mentioned this pull request Apr 10, 2023
1 task
@Torantulino
Copy link
Member

Torantulino commented Apr 10, 2023

While this does require a benchmark for definitive proof, It looks good and I'm happy to merge it.

I'm way too tired to be trusted with that merge conflict right now however, so I'll get to this in the morning.

@nponeccop nponeccop mentioned this pull request Apr 10, 2023
1 task
@nponeccop
Copy link
Contributor

@PhilipAD There are conflicts again

richbeales added a commit that referenced this pull request Apr 15, 2023
@richbeales richbeales merged commit 09f1303 into Significant-Gravitas:master Apr 15, 2023
tgonzales pushed a commit to tgonzales/Auto-GPT that referenced this pull request Apr 19, 2023
Say383 pushed a commit to Say383/Auto-GPT that referenced this pull request Sep 8, 2023
SquareandCompass pushed a commit to SquareandCompass/Auto-GPT that referenced this pull request Oct 21, 2023
sindlinger pushed a commit to Orgsindlinger/Auto-GPT-WebUI that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants