fix(agent): Fix check when loading an existing agent #7026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for auto-gpt-docs canceled.
|
kcze
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7026 +/- ##
=======================================
Coverage 45.51% 45.51%
=======================================
Files 139 139
Lines 6530 6530
Branches 917 917
=======================================
Hits 2972 2972
Misses 3408 3408
Partials 150 150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pwuts
reviewed
Mar 22, 2024
Comment on lines
+188
to
+190
| if re.match(r"^\d+$", load_existing_agent.strip()) and 0 < int( | ||
| load_existing_agent | ||
| ) <= len(existing_agents): |
There was a problem hiding this comment.
Cool! I didn't know Python could do x < y < z comparisons :)
Pwuts
approved these changes
Mar 22, 2024
kcze
deleted the
kpczerwinski/open-185-indexerror-list-index-out-of-range
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPEN-185
Now the check also ensures the chosen agent number is within proper range.