Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change agbenchmark to directory dependency in autogpt and forge #6946

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Feb 29, 2024

Poetry recently released a new version containing a fix for the issue we were having earlier:
python-poetry/poetry#8548

This means unavailable optional directory dependencies should no longer break the docker build.

Using directory dependencies has the advantage that we don't have to manually chore: Update 'agbenchmark' dependency for agent and forge (see commit history), because they'll always import the package directly from the folder in the local repo.

Changes 🏗️

  • Change agbenchmark dependency in forge/pyproject.toml to a directory dependency
    • Update poetry.lock
  • Change agbenchmark dependency in autogpt/pyproject.toml to a directory dependency
    • Update poetry.lock

PR Quality Scorecard ✨

  • Have you used the PR description template?   +2 pts
  • Is your pull request atomic, focusing on a single change?   +5 pts
  • Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
  • Have you documented your changes clearly and comprehensively?   +5 pts
  • Have you changed or added a feature?   -4 pts
    • Have you added/updated corresponding documentation?   +4 pts
    • Have you added/updated corresponding integration tests?   +5 pts
  • Have you changed the behavior of AutoGPT?   -5 pts
    • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

…`forge`

Poetry recently released a new version containing a fix for the issue we were having earlier:
python-poetry/poetry#8548

This means unavailable optional directory dependencies should no longer break the docker build.
@Pwuts Pwuts requested a review from a team as a code owner February 29, 2024 18:11
@Pwuts Pwuts added the docker label Feb 29, 2024
Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit e87af55
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/65e0c8c0f76bdb0008b0572a
😎 Deploy Preview https://deploy-preview-6946--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.11%. Comparing base (2c96f61) to head (e87af55).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6946   +/-   ##
=======================================
  Coverage   45.11%   45.11%           
=======================================
  Files         140      140           
  Lines        6408     6408           
  Branches      897      897           
=======================================
  Hits         2891     2891           
  Misses       3368     3368           
  Partials      149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pwuts Pwuts added the setup Issues with getting Auto-GPT setup on local machines label Feb 29, 2024
@Pwuts Pwuts merged commit 40f98f0 into master Feb 29, 2024
18 checks passed
@Pwuts Pwuts deleted the relative-sibling-dependencies branch February 29, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker setup Issues with getting Auto-GPT setup on local machines size/m
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant