-
Notifications
You must be signed in to change notification settings - Fork 44.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPEN-165: Improvement - check for duplicate command #6937
OPEN-165: Improvement - check for duplicate command #6937
Conversation
Raise in `parse_and_process_response` if the same operation already happened
β Deploy Preview for auto-gpt-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is clean, but too restrictive, as it disallows ever executing the same command twice within the same session. The only repetition that makes sense to directly disallow is executing the same command twice in succession.
Sensibly disallowing later re-execution would require more complex logic to determine whether the effect of a command has been compounded/altered since it was executed.
I modified it, so it only checks the last command executed.
I'll do this in another PR, when I remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changes ποΈ
Raise in
parse_and_process_response
insideagent.py
if agent tries to execute the same command twice in a row.PR Quality Scorecard β¨
+2 pts
+5 pts
+5 pts
+5 pts
-4 pts
+4 pts
+5 pts
-5 pts
agbenchmark
to verify that these changes do not regress performance? β+10 pts