Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing support for AzureOpenAI #6927

Merged
merged 7 commits into from
Feb 29, 2024
Merged

Conversation

edwardsp
Copy link
Contributor

@edwardsp edwardsp commented Feb 27, 2024

Background

The latest master branch is not working for AzureOpenAI

Changes 🏗️

When listing models it was not even considering AzureOpenAI but for other calls it was passing ******instead of the
argument as it was using SecretStr.

PR Quality Scorecard ✨

  • Have you used the PR description template?   +2 pts
  • Is your pull request atomic, focusing on a single change?   +5 pts
  • Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
  • Have you documented your changes clearly and comprehensively?   +5 pts
  • Have you changed or added a feature?   -4 pts
    • Have you added/updated corresponding documentation?   +4 pts
    • Have you added/updated corresponding integration tests?   +5 pts
  • Have you changed the behavior of AutoGPT?   -5 pts
    • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

@edwardsp edwardsp requested a review from a team as a code owner February 27, 2024 16:44
Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit 11ca250
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/65e0bf7d31d30000085863fc
😎 Deploy Preview https://deploy-preview-6927--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unmasking the secrets should be handled in OpenAICredentials.get_api_access_kwargs. I see azure_endpoint isn't being handled properly in that function.

The fix:
image

@Pwuts
Copy link
Member

Pwuts commented Feb 29, 2024

AutoGPT Python CI / lint (pull_request)   Failing after 1m

Please run isort . and black .

@Pwuts Pwuts merged commit 50e5ea4 into Significant-Gravitas:master Feb 29, 2024
9 of 13 checks passed
@Pwuts
Copy link
Member

Pwuts commented Feb 29, 2024

Thank you @edwardsp!

KidiIT

This comment was marked as spam.

@Significant-Gravitas Significant-Gravitas deleted a comment from sentry-io bot Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants