Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update execute_code.py #6903

Merged
merged 7 commits into from
Feb 27, 2024
Merged

Update execute_code.py #6903

merged 7 commits into from
Feb 27, 2024

Conversation

ehtec
Copy link
Contributor

@ehtec ehtec commented Feb 24, 2024

Background

Fix code execution issue

@ehtec ehtec requested a review from a team as a code owner February 24, 2024 02:20
@netlify Netlify
Copy link

netlify bot commented Feb 24, 2024 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit 68e17ae
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/65ddd42d60cb6b0009f0b034
😎 Deploy Preview https://deploy-preview-6903--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ntindle ntindle requested a review from Pwuts February 26, 2024 02:50
Pwuts
Pwuts requested changes Feb 26, 2024
View reviewed changes
Copy link
Member

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR! Aside from a few linting errors (fixed) and minor requests for clarification (below), it looks good.

autogpts/autogpt/autogpt/commands/execute_code.py Outdated Show resolved Hide resolved
autogpts/autogpt/autogpt/commands/execute_code.py Outdated Show resolved Hide resolved
autogpts/autogpt/autogpt/commands/execute_code.py Outdated Show resolved Hide resolved
@Pwuts Pwuts self-assigned this Feb 26, 2024
@Pwuts Pwuts added this to the AutoGPT v0.6.0 milestone Feb 26, 2024
@Pwuts
Copy link
Member

Pwuts commented Feb 26, 2024

Don't worry about the (Docker|Python) CI / test checks failing, they fail for lack of access to OpenAI and this is not due to changes you made.

Pwuts added 2 commits February 27, 2024 13:09
@Pwuts
refactor: Simplify logic for checking shell commands and reduce diff …
253ce57 
…with `master`
@Pwuts
refactor & docs: Clarify validate_command function
68e17ae 
* Rename `command` parameter to `command_line`
* Amend docstring to explain logic for allowing/denying shell execution
@Pwuts Pwuts merged commit 5090f55 into Significant-Gravitas:master Feb 27, 2024
10 of 13 checks passed
@Significant-Gravitas Significant-Gravitas deleted a comment from sentry-io bot Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pwuts Pwuts Pwuts requested changes

Assignees

@Pwuts Pwuts

Labels
function: run shell commands function: speech Security 🛡️ size/m
Projects
AutoGPT development kanban
Status: ✅ Done
Milestone
AutoGPT v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ehtec @Pwuts