Fixed revising constraints and best practices

[ThunderDrag]

Background

When using AutoGPT I noticed that it starts to skip constraints and best practices when you use "-" to remove them, it seems like that happens because the constraints are removed in the for loop immediately thus shortening the list and skipping over other constraints.

Changes 🏗️

I have made an list for constraints and best practices each, the ones designated for removal are added to that list and removed after the for loop has finished

PR Quality Scorecard ✨

• Have you used the PR description template?   +2 pts
• Is your pull request atomic, focusing on a single change?   +5 pts
• Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
• Have you documented your changes clearly and comprehensively?   +5 pts
• Have you changed or added a feature?   -4 pts
  • Have you added/updated corresponding documentation?   +4 pts
  • Have you added/updated corresponding integration tests?   +5 pts
• Have you changed the behavior of AutoGPT?   -5 pts
  • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

[netlify]

✅ Deploy Preview for auto-gpt-docs ready!

Name	Link
🔨 Latest commit	fe72973
🔍 Latest deploy log	https://app.netlify.com/sites/auto-gpt-docs/deploys/65d474c23261c50008ef1834
😎 Deploy Preview	https://deploy-preview-6777--auto-gpt-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Pwuts]

You're right about the bug, a for loop doesn't like in-place removal of items. Nice catch!

[Pwuts]

The fix could be a bit simpler though, by turning the for loop into a while loop, like this:

        # Revise constraints
-       for i, constraint in enumerate(directives.constraints):
+       i = 0
+       while i < len(directives.constraints)
+           constraint = directives.constraints[i]
            print_attribute(f"Constraint {i+1}:", f'"{constraint}"')
            new_constraint = (
                await clean_input(
                    app_config,
                    f"Enter new constraint {i+1}"
                    " (press enter to keep current, or '-' to remove):",
                )
                or constraint
            )
            if new_constraint == "-":
                directives.constraints.remove(constraint)
+               continue
            elif new_constraint:
                directives.constraints[i] = new_constraint
+           i += 1

[ThunderDrag]

Made the requested changes

[Pwuts]

Please run poetry run black . && poetry run flake8 . (in autogpts/autogpt folder): https://github.com/Significant-Gravitas/AutoGPT/actions/runs/7759553508/job/21164192021?pr=6777

[ThunderDrag]

I have ran the commands

[Pwuts]

I'm not sure what happened, but it looks like the linter ran with the wrong settings (probably because of wrong CWD). Diff now contains a lot of code formatting changes that are outside the scope of the PR.

[github-actions]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

[ntindle]

You can probably revert this commit and try again 2bd8a50

[ThunderDrag]

Rebased it

[github-actions]

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

[Pwuts]

Thank you very much :)