Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix No modules named 'forge.sdk.abilities' and 'forge.sdk' #6537 #5810 #6571

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

kfern
Copy link
Contributor

@kfern kfern commented Dec 15, 2023

This PR fix #6537 and #5810 issues as described in #6537 (comment)

Background

./run agent start forge doesn`t work without this changes

Changes 🏗️

  1. in registry.py, forge.sdk.abilities needs to be replaced with forge.actions.
  2. in finish.py in the same folder the first import needs to be changed from from sdk.forge_log import ForgeLogger to from forge.sdk.forge_log import ForgeLogger

PR Quality Scorecard ✨

  • Have you used the PR description template?   +2 pts
  • Is your pull request atomic, focusing on a single change?   +5 pts
  • Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
  • Have you documented your changes clearly and comprehensively?   +5 pts
  • Have you changed or added a feature?   -4 pts
    • Have you added/updated corresponding documentation?   +4 pts
    • Have you added/updated corresponding integration tests?   +5 pts
  • Have you changed the behavior of AutoGPT?   -5 pts
    • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

@kfern kfern requested a review from Swiftyos as a code owner December 15, 2023 10:24
Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit b708f2a
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/65ba1dd42f48c20008f00e66
😎 Deploy Preview https://deploy-preview-6571--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ntindle ntindle requested a review from Pwuts December 17, 2023 16:03
@Wladastic
Copy link
Contributor

@Pwuts I think this makes sense. Probably this part was forgotten in the mentioned commit: 78f5ff1

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jan 16, 2024
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@Morriz
Copy link

Morriz commented Jan 16, 2024

bump!

@kfern kfern requested a review from a team January 20, 2024 18:40
@kfern kfern requested a review from a team as a code owner January 20, 2024 18:40
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot added size/xl and removed conflicts Automatically applied to PRs with merge conflicts size/s labels Jan 20, 2024
Copy link
Contributor

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

jkbh added a commit to jkbh/AutoGPT that referenced this pull request Jan 22, 2024
@Morriz
Copy link

Morriz commented Jan 23, 2024

almost there! please update the base branch @jkbh ;)

@github-actions github-actions bot added size/s and removed size/xl labels Jan 23, 2024
spisupat added a commit to spisupat/AutoGPT that referenced this pull request Jan 29, 2024
@Pwuts Pwuts linked an issue Feb 1, 2024 that may be closed by this pull request
1 task
@Pwuts Pwuts merged commit 266fe3a into Significant-Gravitas:master Feb 1, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
5 participants