Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating duckduckgo version #6557

Closed
wants to merge 2 commits into from

Conversation

zedatrix
Copy link
Contributor

During testing for the v0.5.0 release, we discovered web search was not working as expected. This was due to an old version of the sdk being used. This pull request just updates the version to 4 (currently the latest) and also changes the forge to local to use the changes. We should either add this to the docs or leave it default to local i think.

Copy link
Contributor

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit c490dbc
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6578c04301673f000801a221
😎 Deploy Preview https://deploy-preview-6557--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added size/m and removed size/xl labels Dec 12, 2023
@Pwuts Pwuts linked an issue Dec 13, 2023 that may be closed by this pull request
1 task
Comment on lines -25 to +27
# autogpt-forge = { path = "../forge" }
autogpt-forge = {git = "https://github.com/Significant-Gravitas/AutoGPT.git", subdirectory = "autogpts/forge"}
#TODO: Add this to the documentation so people can use the local or remote version. E.g. setting to local was the only way to fix the duck duck go dependency issue.
autogpt-forge = { path = "../forge" }
#autogpt-forge = {git = "https://github.com/Significant-Gravitas/AutoGPT.git", subdirectory = "autogpts/forge"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the Docker build.

Copy link
Contributor Author

@zedatrix zedatrix Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh because it needs a remote repo.. ok I wanted to make it a flag anyways.. I can add that maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe the Dockerfile file can account for it?

@Pwuts
Copy link
Member

Pwuts commented Dec 13, 2023

The proper way to do this would be:

  1. Update duckduckgo-search in forge
  2. Update forge and duckduckgo-search in autogpt

This has to happen in 2 separate commits, because autogpt/poetry.lock needs to reference a specific commit for its forge dependency.

Unfortunately this is much more of a hassle with PRs than with direct commits. :')

@Pwuts
Copy link
Member

Pwuts commented Dec 13, 2023

There was a bit of time pressure on this, so I adopted your fix in d820239. Thanks for figuring it out! :)

@Pwuts Pwuts closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

web_search command always returns [] in AutoGPT v0.4.7
2 participants