Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker build. Changing agbenchmark dependency as git reference instead of folder reference. #6274

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

warnyul
Copy link
Contributor

@warnyul warnyul commented Nov 17, 2023

Changing agbenchmark dependency as git reference instead of folder reference.

Background

When building the autogpt docker image, then only the autogpts/autogpt folder is copied into the Docker image.
So, when poetry install --root tries to install the dependencies in the image, it will not work, because the benchmark folder is not in the image. As JulianBroudy's commented the logs under #5253. So, I changed the dependency to a git reference which makes the agbenchmark accessible from the Docker image.

Related issues:

Changes 🏗️

  • Updated autogpts/autogpt/pyproject.toml. Changed agbenchmark from folder to git reference and run poetry update agbencmark to update the poetry.lock file.
  • Updated autogpts/forge/pyproject.toml. Changed agbenchmark from folder to git reference and run poetry update agbencmark to update the poetry.lock file.

PR Quality Scorecard ✨

  • Have you used the PR description template?   +2 pts
  • Is your pull request atomic, focusing on a single change?   +5 pts
  • Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
  • Have you documented your changes clearly and comprehensively?   +5 pts
  • Have you changed or added a feature?   -4 pts
    • Have you added/updated corresponding documentation?   +4 pts
    • Have you added/updated corresponding integration tests?   +5 pts
  • Have you changed the behavior of AutoGPT?   -5 pts
    • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

Changing agbenchmark dependency as git reference instead of folder reference.
Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit 8467e06
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/65589d1df2efa4000808353b
😎 Deploy Preview https://deploy-preview-6274--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Pwuts Pwuts changed the title Fix docker build. Changing agbenchmark dependency as git reference instead of folder reference. #6191 Fix docker build. Changing agbenchmark dependency as git reference instead of folder reference. Nov 21, 2023
@Pwuts Pwuts added setup Issues with getting Auto-GPT setup on local machines docker labels Nov 21, 2023
@Pwuts
Copy link
Member

Pwuts commented Nov 21, 2023

We strongly prefer to have it as a path dependency because that allows more agility in developing the packages in the repo. Also, we have a fix on the way: python-poetry/poetry#8549

I'll look into adopting (part of) your fix in the meantime, as the main issue that I'm trying to avoid is dependency insolvency between autogpt and forge.

@Pwuts Pwuts merged commit 155718a into Significant-Gravitas:master Nov 24, 2023
11 of 15 checks passed
@Pwuts
Copy link
Member

Pwuts commented Nov 24, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker setup Issues with getting Auto-GPT setup on local machines size/l
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants