Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix speak mode with elevenlabs falling into error #5127

Merged
merged 0 commits into from
Aug 18, 2023
Merged

Fix speak mode with elevenlabs falling into error #5127

merged 0 commits into from
Aug 18, 2023

Conversation

dannaward
Copy link
Contributor

Background

Running speak mode with elevenLabs on not only stable branch but also master fails with a config error like below.

  File "/Users/danna/Desktop/Personal/Auto-GPT/autogpt/speech/eleven_labs.py", line 46, in _setup
    if config.elevenlabs_voice_2_id in voice_options:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Config' object has no attribute 'elevenlabs_voice_2_id'. Did you mean: 'elevenlabs_voice_id'?

I just followed the guide on docs, and encountered this issue, so I think either the docs or the code should be updated.

Changes

I saw the commit history in which the elevenlabs_voice_2_id was deleted on .env.template, thus instead of adding it again on config.py, I decided to remove elevenlabs_voice_2_id-related-codes on eleven_labs.py. (I assumed eleven_labs.py is the legacy one here)
It's now all synchronized and is not running into errors anymore.

Documentation

Test Plan

It worked fine on both my local environment and docker.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for auto-gpt-docs failed.

Name Link
🔨 Latest commit bed4809
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64dea2ef7faaa00008e75c43

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Aug 17, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added size/xs and removed size/s labels Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bed4809) 51.93% compared to head (bed4809) 51.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5127   +/-   ##
=======================================
  Coverage   51.93%   51.93%           
=======================================
  Files         117      117           
  Lines        4987     4987           
  Branches      671      671           
=======================================
  Hits         2590     2590           
  Misses       2199     2199           
  Partials      198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ntindle ntindle merged commit bed4809 into Significant-Gravitas:master Aug 18, 2023
@dannaward
Copy link
Contributor Author

@ntindle It seems like the commits have disappeared and merged, resulting in no changes made in the master branch. Can you sort out this issue?

@ntindle
Copy link
Member

ntindle commented Aug 18, 2023

I didn't merge this to the best of my knowledge

@ntindle
Copy link
Member

ntindle commented Aug 18, 2023

It appears something force pushed to your branch, did you?

@dannaward
Copy link
Contributor Author

No, I didn't do anything with it in the meantime. Should I create a new pull request?

@dannaward
Copy link
Contributor Author

maybe something related to this log?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Automatically applied to PRs with merge conflicts size/xs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants