Do not load disabled commands (faster exec & benchmark runs) #5078
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Disabled commands need to be unregistered after initializing the registry.
get_command_registry()
wasn't doing this, leading to more prolonged execution and benchmark runs when the disabled command was loaded, failed, and then the correct one was loaded.For example (with no Google API key), we typically see:
Changes
Swapped
get_command_registry
forCommandRegistry.with_command_modules
Documentation
N/A
Test Plan
Local testing
PR Quality Checklist