Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove append to file #5051

Merged
merged 4 commits into from
Jul 29, 2023
Merged

Remove append to file #5051

merged 4 commits into from
Jul 29, 2023

Conversation

waynehamadi
Copy link
Contributor

Background

Not very useful command, write_to_file is more reliable.

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@waynehamadi waynehamadi requested a review from collijk as a code owner July 24, 2023 17:37
@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for auto-gpt-docs failed.

Name Link
🔨 Latest commit 11552fd
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64c551abd9903f00083486fd

@waynehamadi waynehamadi marked this pull request as draft July 24, 2023 17:39
@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@waynehamadi waynehamadi marked this pull request as ready for review July 24, 2023 17:57
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 90.62% and project coverage change: +0.02% 🎉

Comparison is base (c8d9b69) 51.18% compared to head (11552fd) 51.20%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5051      +/-   ##
==========================================
+ Coverage   51.18%   51.20%   +0.02%     
==========================================
  Files         116      116              
  Lines        4937     4937              
  Branches      663      664       +1     
==========================================
+ Hits         2527     2528       +1     
+ Misses       2216     2214       -2     
- Partials      194      195       +1     
Files Changed Coverage Δ
autogpt/commands/file_operations.py 82.40% <ø> (-0.14%) ⬇️
autogpt/config/ai_config.py 73.68% <75.00%> (-2.59%) ⬇️
autogpt/agents/base.py 71.75% <86.36%> (+2.52%) ⬆️
autogpt/agents/agent.py 50.00% <100.00%> (ø)
autogpt/app/setup.py 73.41% <100.00%> (+0.34%) ⬆️
autogpt/config/config.py 80.58% <100.00%> (ø)
autogpt/config/prompt_config.py 76.47% <100.00%> (ø)
autogpt/llm/utils/__init__.py 46.03% <100.00%> (+0.87%) ⬆️
autogpt/prompts/generator.py 95.45% <100.00%> (+2.47%) ⬆️
autogpt/prompts/prompt.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynehamadi waynehamadi force-pushed the remove-append-to-file branch 2 times, most recently from 6c61dbe to f80a19d Compare July 24, 2023 21:41
@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@waynehamadi waynehamadi force-pushed the remove-append-to-file branch from f80a19d to a4e26db Compare July 24, 2023 21:46
Signed-off-by: Merwane Hamadi <[email protected]>
@waynehamadi waynehamadi force-pushed the remove-append-to-file branch from 3bbf498 to 287391e Compare July 24, 2023 21:53
@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@waynehamadi waynehamadi merged commit 45c9566 into master Jul 29, 2023
@waynehamadi waynehamadi deleted the remove-append-to-file branch July 29, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants