Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delete file #5050

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Remove delete file #5050

merged 1 commit into from
Jul 24, 2023

Conversation

waynehamadi
Copy link
Contributor

Background

How many user experiences got ruined because of this command ?

And what does it bring ? Yeah it can be useful, but come on, it's not critical.

Without this command Auto-GPT becomes way more reliable at doing tasks without deleting them.

Changes

  • remove delete_file command

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for auto-gpt-docs failed.

Name Link
🔨 Latest commit b6d9c3a
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64beb1bb3ee81400078c1e7d

@waynehamadi waynehamadi requested a review from collijk as a code owner July 24, 2023 17:10
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06 ⚠️

Comparison is base (bf8f586) 51.23% compared to head (b6d9c3a) 51.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5050      +/-   ##
==========================================
- Coverage   51.23%   51.17%   -0.06%     
==========================================
  Files         116      116              
  Lines        4944     4934      -10     
  Branches      664      663       -1     
==========================================
- Hits         2533     2525       -8     
+ Misses       2216     2215       -1     
+ Partials      195      194       -1     
Impacted Files Coverage Δ
autogpt/commands/file_operations.py 82.53% <ø> (+0.05%) ⬆️
autogpt/core/planning/templates.py 0.00% <ø> (ø)
autogpt/agents/base.py 69.49% <100.00%> (+0.26%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Merwane Hamadi <[email protected]>
@Swiftyos Swiftyos merged commit c148140 into master Jul 24, 2023
@Swiftyos Swiftyos deleted the remove-delete-file branch July 24, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants