Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime error in the API #5047

Merged
merged 5 commits into from
Jul 24, 2023
Merged

Conversation

ValentaTomas
Copy link
Contributor

Background

I found a runtime error in the API mainly caused by a wrong variable access.

Changes

The changes I made are in the cli_web_app directory - I fixed the error and updated the files to work with some changes to the other parts of AutoGPT.

Documentation

I need to document the changes and the new functionality.

Test Plan

I still need to thoroughly test these changes.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for auto-gpt-docs failed.

Name Link
🔨 Latest commit c340e18
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64be68c1a19480000898fd21

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 5.88% and project coverage change: +0.22 🎉

Comparison is base (4ada7d1) 51.00% compared to head (c340e18) 51.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5047      +/-   ##
==========================================
+ Coverage   51.00%   51.23%   +0.22%     
==========================================
  Files         119      116       -3     
  Lines        4968     4944      -24     
  Branches      662      664       +2     
==========================================
- Hits         2534     2533       -1     
+ Misses       2239     2216      -23     
  Partials      195      195              
Impacted Files Coverage Δ
autogpt/app/main.py 39.74% <0.00%> (ø)
autogpt/core/runner/cli_web_app/cli.py 0.00% <0.00%> (ø)
autogpt/core/runner/cli_web_app/server/api.py 0.00% <0.00%> (ø)
autogpt/agents/agent.py 49.60% <100.00%> (-0.40%) ⬇️
autogpt/workspace/workspace.py 92.59% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynehamadi waynehamadi marked this pull request as ready for review July 24, 2023 15:32
@waynehamadi waynehamadi requested a review from collijk as a code owner July 24, 2023 15:32
@waynehamadi waynehamadi merged commit abed282 into Significant-Gravitas:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants