-
Notifications
You must be signed in to change notification settings - Fork 44.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slips of the pen (bloopers) in autogpt/core part of the repo #5045
Merged
collijk
merged 9 commits into
Significant-Gravitas:master
from
cyrus-hawk:a-slip-of-a-pen
Aug 1, 2023
Merged
slips of the pen (bloopers) in autogpt/core part of the repo #5045
collijk
merged 9 commits into
Significant-Gravitas:master
from
cyrus-hawk:a-slip-of-a-pen
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for auto-gpt-docs failed.
|
collijk
previously approved these changes
Jul 24, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5045 +/- ##
==========================================
- Coverage 51.95% 51.94% -0.01%
==========================================
Files 116 116
Lines 4987 4976 -11
Branches 671 668 -3
==========================================
- Hits 2591 2585 -6
+ Misses 2198 2196 -2
+ Partials 198 195 -3
☔ View full report in Codecov by Sentry. |
cyrus-hawk
changed the title
fix omitted "()" in __str__(self) in core/ability/base.py
slips of the pen (bloopers) in autogpt/core part of the repo
Jul 25, 2023
autogpt/core/resourece/model_providers/openai.py
collijk
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I'm trying to write some pytests for the core part of the Auto-GPT, I sometimes notice some bloopers along the way. These are subtle mistakes that sometimes elude our eyes.
Changes
I try to fix them with minimum required changes.
Documentation
NA
Test Plan
pytests are written for these changes, to make sure everything is run smoothly.
PR Quality Checklist