Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workspace crashing #5041

Merged

Conversation

waynehamadi
Copy link
Contributor

@waynehamadi waynehamadi commented Jul 22, 2023

Background

Changes

Fix the workspace crashing

Documentation

  • it's weird the methods being called were doing nothing. they were modifying a config without returning it.
  • use config.workspace_path

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jul 22, 2023

Deploy Preview for auto-gpt-docs failed.

Name Link
🔨 Latest commit 09c89a3
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64bdf8188d4e930008c7c443

Signed-off-by: Merwane Hamadi <[email protected]>
@waynehamadi waynehamadi force-pushed the fix-workspace-crashing branch from a9eccfb to a8be19f Compare July 22, 2023 23:48
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.01 ⚠️

Comparison is base (4ada7d1) 51.00% compared to head (a8be19f) 50.99%.

❗ Current head a8be19f differs from pull request most recent head 09c89a3. Consider uploading reports for the commit 09c89a3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5041      +/-   ##
==========================================
- Coverage   51.00%   50.99%   -0.01%     
==========================================
  Files         119      119              
  Lines        4968     4967       -1     
  Branches      662      662              
==========================================
- Hits         2534     2533       -1     
  Misses       2239     2239              
  Partials      195      195              
Impacted Files Coverage Δ
autogpt/app/main.py 39.74% <0.00%> (ø)
autogpt/agents/agent.py 49.60% <100.00%> (-0.40%) ⬇️
autogpt/workspace/workspace.py 92.59% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynehamadi waynehamadi merged commit 60d0f5e into Significant-Gravitas:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants