Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/bad null byte #5033

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Bugfix/bad null byte #5033

merged 2 commits into from
Jul 21, 2023

Conversation

collijk
Copy link
Contributor

@collijk collijk commented Jul 21, 2023

Background

There are bad null characters in our null byte check (some representations that came from https://en.wikipedia.org/wiki/Null_character but are not relevant to us).

Changes

  • Remove the r"\z" null byte (which just blocks paths that start with z on windows).
  • Remove the "%00" null byte, which is relevant to urls but not file paths.

Documentation

X

Test Plan

CI

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@collijk collijk requested a review from Pwuts July 21, 2023 16:05
@netlify
Copy link

netlify bot commented Jul 21, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit c7fa76a
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64baacc376617f0008655a7f

@collijk collijk added this to the v0.4.6 Release milestone Jul 21, 2023
@collijk collijk added bug Something isn't working platform dependent When something works but not on all platforms function: workspace and removed size/s labels Jul 21, 2023
@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 59.71% and project coverage change: +0.18 🎉

Comparison is base (08a1e22) 50.93% compared to head (c7fa76a) 51.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5033      +/-   ##
==========================================
+ Coverage   50.93%   51.12%   +0.18%     
==========================================
  Files         119      119              
  Lines        4900     4984      +84     
  Branches      650      663      +13     
==========================================
+ Hits         2496     2548      +52     
- Misses       2219     2239      +20     
- Partials      185      197      +12     
Impacted Files Coverage Δ
autogpt/llm/__init__.py 100.00% <ø> (ø)
autogpt/llm/providers/openai.py 89.07% <ø> (ø)
autogpt/memory/vector/utils.py 75.60% <ø> (+3.51%) ⬆️
autogpt/agents/agent.py 50.00% <47.12%> (-4.12%) ⬇️
autogpt/main.py 39.88% <51.48%> (+16.19%) ⬆️
autogpt/agents/base.py 69.23% <69.23%> (ø)
autogpt/memory/message_history.py 78.49% <71.42%> (-3.23%) ⬇️
autogpt/json_utils/utilities.py 66.66% <72.72%> (-2.57%) ⬇️
autogpt/spinner.py 97.36% <90.00%> (+5.06%) ⬆️
autogpt/agents/__init__.py 100.00% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@collijk collijk merged commit 8503e96 into master Jul 21, 2023
@collijk collijk deleted the bugfix/bad-null-byte branch July 21, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behaviour change bug Something isn't working function: workspace platform dependent When something works but not on all platforms
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants