Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runner.cli parsers set as a library #5021

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

ph-ausseil
Copy link
Contributor

@ph-ausseil ph-ausseil commented Jul 20, 2023

Background

As there are plan to build a web-app , and add modularity to the code, it would be beneficial to set the parser as a library.

Changes

Move the parser in a separate file

Documentation

Test Plan

Run.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@ph-ausseil ph-ausseil requested a review from collijk as a code owner July 20, 2023 11:35
@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 864385f
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64b94724f0ca030008207210

@collijk
Copy link
Contributor

collijk commented Jul 20, 2023

Yes, these definitely belong in a client lib.

@collijk collijk merged commit 307644a into Significant-Gravitas:master Jul 20, 2023
@Pwuts Pwuts added the re-arch label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants