Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuring TTS engine #5005

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Fix configuring TTS engine #5005

merged 1 commit into from
Jul 18, 2023

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Jul 18, 2023

Background

TEXT_TO_SPEECH_PROVIDER is bulldozed in ConfigBuilder.build_config_from_env():

Changes

  • Enclose the offending piece of code in an if not config_dict["text_to_speech_provider"]
  • Get config values from config_dict instead of repeatedly calling os.getenv for the same variable

Documentation

x

Test Plan

CI

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@Pwuts Pwuts added this to the v0.4.6 Release milestone Jul 18, 2023
@Pwuts Pwuts added bug Something isn't working function: speech labels Jul 18, 2023
@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 4312543
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64b6973186cc5b0008617ae5

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 22.22% and project coverage change: -0.03 ⚠️

Comparison is base (a758ace) 51.02% compared to head (4312543) 51.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5005      +/-   ##
==========================================
- Coverage   51.02%   51.00%   -0.03%     
==========================================
  Files         118      118              
  Lines        4898     4898              
  Branches      649      650       +1     
==========================================
- Hits         2499     2498       -1     
  Misses       2215     2215              
- Partials      184      185       +1     
Impacted Files Coverage Δ
autogpt/config/config.py 80.00% <22.22%> (-0.61%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@collijk collijk merged commit 0c94bb5 into master Jul 18, 2023
@collijk collijk deleted the fix/config-tts-engine branch July 18, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants