Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix execute_python_file workspace mount & Windows path formatting #4996

Merged
merged 4 commits into from
Jul 17, 2023
Merged

Fix execute_python_file workspace mount & Windows path formatting #4996

merged 4 commits into from
Jul 17, 2023

Conversation

sohrabsaran
Copy link
Contributor

@sohrabsaran sohrabsaran commented Jul 17, 2023 •
edited
Loading

Background

Please see #4975

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters: 
    black .
isort .
mypy
autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jul 17, 2023 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 4a66b4d
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64b58162571f640008be6a4f

@codecov
Copy link

codecov bot commented Jul 17, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (5ae044f) 51.02% compared to head (4a66b4d) 51.02%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4996   +/-   ##
=======================================
  Coverage   51.02%   51.02%           
=======================================
  Files         118      118           
  Lines        4898     4898           
  Branches      649      649           
=======================================
  Hits         2499     2499           
  Misses       2215     2215           
  Partials      184      184
Impacted Files Coverage Δ
autogpt/commands/execute_code.py 71.96% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pwuts Pwuts changed the title 4975_fix Fix execute_python_file path formatting on Windows Jul 17, 2023
@Pwuts Pwuts changed the title Fix execute_python_file path formatting on Windows Fix execute_python_file workspace mount & Windows path formatting Jul 17, 2023
@Pwuts Pwuts added bug Something isn't working docker labels Jul 17, 2023
@Pwuts Pwuts added this to the v0.4.6 Release milestone Jul 17, 2023
@Pwuts Pwuts self-assigned this Jul 17, 2023
@Pwuts Pwuts merged commit a758ace into Significant-Gravitas:master Jul 17, 2023
@Pwuts Pwuts mentioned this pull request Jul 17, 2023
Closed
1 task
@sohrabsaran sohrabsaran deleted the 4975_fix branch July 18, 2023 04:02
@sohrabsaran
Copy link
Contributor Author

Thank you @Pwuts !

waynehamadi pushed a commit to waynehamadi/Auto-GPT that referenced this pull request Jul 18, 2023
@sohrabsaran @Pwuts @waynehamadi
Fix execute_python_file workspace mount & Windows path formatting (S…
50e0b7d 
…ignificant-Gravitas#4996)

* fix for Significant-Gravitas#4975

* Add TODO based on code comment.

* Use builtin `Path.as_posix()`

* Remove TODO

---------

Co-authored-by: Reinier van der Leer <[email protected]>
Signed-off-by: Merwane Hamadi <[email protected]>
@waynehamadi waynehamadi mentioned this pull request Jul 18, 2023
Closed
6 tasks
waynehamadi pushed a commit to waynehamadi/Auto-GPT that referenced this pull request Jul 18, 2023
@sohrabsaran @Pwuts @waynehamadi
Fix execute_python_file workspace mount & Windows path formatting (S…
fb4a1d3 
…ignificant-Gravitas#4996)

* fix for Significant-Gravitas#4975

* Add TODO based on code comment.

* Use builtin `Path.as_posix()`

* Remove TODO

---------

Co-authored-by: Reinier van der Leer <[email protected]>
Signed-off-by: Merwane Hamadi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pwuts Pwuts Pwuts approved these changes

Assignees

@Pwuts Pwuts

Labels
bug Something isn't working docker size/s
Projects
AutoGPT development kanban
Archived in project
Milestone
v0.4.6 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@sohrabsaran @Pwuts