Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle plugin loading failure #4994

Merged
merged 6 commits into from
Jul 22, 2023

Conversation

eyalk11
Copy link
Contributor

@eyalk11 eyalk11 commented Jul 17, 2023

Background

If module import of a plugin failed , there is an unnecessary exception currently. Fixed that.

Changes

Those are the changes.

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit af577a5
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64bb52cf3468cb0008e7ea59
😎 Deploy Preview https://deploy-preview-4994--auto-gpt-docs.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.04 ⚠️

Comparison is base (669e66a) 51.03% compared to head (af577a5) 51.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4994      +/-   ##
==========================================
- Coverage   51.03%   51.00%   -0.04%     
==========================================
  Files         119      119              
  Lines        4961     4968       +7     
  Branches      662      662              
==========================================
+ Hits         2532     2534       +2     
- Misses       2234     2239       +5     
  Partials      195      195              
Impacted Files Coverage Δ
autogpt/plugins/__init__.py 71.08% <50.00%> (-1.88%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eyalk11 eyalk11 mentioned this pull request Jul 17, 2023
5 tasks
@Pwuts Pwuts added this to the v0.4.6 Release milestone Jul 17, 2023
@Pwuts Pwuts self-assigned this Jul 17, 2023
autogpt/plugins/__init__.py Outdated Show resolved Hide resolved
autogpt/plugins/__init__.py Outdated Show resolved Hide resolved
@Pwuts Pwuts changed the title add plugin loading error handling Gracefully handle plugin loading failure Jul 17, 2023
@eyalk11 eyalk11 requested a review from Pwuts July 19, 2023 00:04
Pwuts
Pwuts previously requested changes Jul 21, 2023
Copy link
Member

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, almost there :)

autogpt/plugins/__init__.py Outdated Show resolved Hide resolved
Co-authored-by: Reinier van der Leer <[email protected]>
Copy link
Contributor

@lc0rp lc0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the requested changes were applied. Merging

@lc0rp lc0rp dismissed Pwuts’s stale review July 22, 2023 05:42

Looks like the requested change was applied.

@lc0rp lc0rp merged commit 2954735 into Significant-Gravitas:master Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants