Replaced Fictitious color name Fore.ORANGE #4972
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… not support an ORANGE color. This fixes a fatal error in run.sh when trying to set the API key through the input() method.
Background
config.py
had a fictitious name, Colorama.Fore.ORANGE, which does not exist according to The Current PyPi Page for Colorama. This was discussed with the maintainers and the change was approved.Changes
I have changed it from Fore.ORANGE ---> Fore.YELLOW. Yellow is a common color for warning messages, which the Fore is applied to, so it is still clear.
Documentation
Change is very small, I don't belive this is applicable.
Test Plan
Before, when
run.sh
was run, it would produce a fatal error,"AttributeError: 'Ansifore' Object has no attribute 'ORANGE'
. This has been eliminated, since the name was fictitious, and now it has been changed to something that exists within thecolorama
module. The probability of this bug re-emerging is low.PR Quality Checklist
Discussed with maintainers on discord.
Yes.