Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Fictitious color name Fore.ORANGE #4972

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

GECORegulatory
Copy link
Contributor

… not support an ORANGE color. This fixes a fatal error in run.sh when trying to set the API key through the input() method.

Background

config.py had a fictitious name, Colorama.Fore.ORANGE, which does not exist according to The Current PyPi Page for Colorama. This was discussed with the maintainers and the change was approved.

Changes

I have changed it from Fore.ORANGE ---> Fore.YELLOW. Yellow is a common color for warning messages, which the Fore is applied to, so it is still clear.

Documentation

Change is very small, I don't belive this is applicable.

Test Plan

Before, when run.sh was run, it would produce a fatal error, "AttributeError: 'Ansifore' Object has no attribute 'ORANGE' . This has been eliminated, since the name was fictitious, and now it has been changed to something that exists within the colorama module. The probability of this bug re-emerging is low.

PR Quality Checklist

  • [Yes] My pull request is atomic and focuses on a single change.
  • [ Yes ] I have thoroughly tested my changes with multiple different prompts.
  • [ Yes ] I have considered potential risks and mitigations for my changes.
  • [ Yes ] I have documented my changes clearly and comprehensively.
  • [ Yes ] I have not snuck in any "extra" small tweaks changes.
  • [ Yes ] I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

Discussed with maintainers on discord.

Yes.

… not support an ORANGE color. This fixes a fatal error in run.sh when trying to set the API key through the input() method.
@netlify
Copy link

netlify bot commented Jul 14, 2023

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit 5153992
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64b172a7d7663d0008c24ebe
😎 Deploy Preview https://deploy-preview-4972--auto-gpt-docs.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7c4fc45) 51.00% compared to head (5153992) 51.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4972   +/-   ##
=======================================
  Coverage   51.00%   51.00%           
=======================================
  Files         118      118           
  Lines        4884     4884           
  Branches      643      643           
=======================================
  Hits         2491     2491           
  Misses       2212     2212           
  Partials      181      181           
Impacted Files Coverage Δ
autogpt/config/config.py 80.60% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@collijk collijk merged commit 376ecf0 into Significant-Gravitas:master Jul 14, 2023
dayofthedave pushed a commit to dayofthedave/Auto-GPT that referenced this pull request Jul 17, 2023
Changed Colorama.Fore.ORANGE to YELLOW in config.py, As Colorama does not support an ORANGE color. This fixes a fatal error in run.sh when trying to set the API key through the input() method.

Co-authored-by: James Collins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants