Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/rename agent subpackage to agents #4961

Conversation

collijk
Copy link
Contributor

@collijk collijk commented Jul 13, 2023

Background

#4799 is working on a bunch of important tasks, but includes a rename refactor which makes the PR hard to review for details.

Changes

  • Rename the agent subpackage to agents.

Documentation

X

Test Plan

CI and manual testing

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@collijk collijk requested a review from Pwuts July 13, 2023 03:58
@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit f9fced5
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64b00a0e0042e1000774250f

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 84.61% and no project coverage change.

Comparison is base (4177c37) 51.00% compared to head (8a5036d) 51.00%.

❗ Current head 8a5036d differs from pull request most recent head f9fced5. Consider uploading reports for the commit f9fced5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4961   +/-   ##
=======================================
  Coverage   51.00%   51.00%           
=======================================
  Files         118      118           
  Lines        4884     4884           
  Branches      643      643           
=======================================
  Hits         2491     2491           
  Misses       2212     2212           
  Partials      181      181           
Impacted Files Coverage Δ
autogpt/agents/agent.py 54.11% <ø> (ø)
autogpt/llm/chat.py 60.97% <0.00%> (ø)
autogpt/memory/message_history.py 81.72% <0.00%> (ø)
autogpt/agents/__init__.py 100.00% <100.00%> (ø)
autogpt/commands/decorators.py 78.94% <100.00%> (ø)
autogpt/commands/execute_code.py 71.96% <100.00%> (ø)
autogpt/commands/file_operations.py 82.48% <100.00%> (ø)
autogpt/commands/git_operations.py 93.75% <100.00%> (ø)
autogpt/commands/image_gen.py 74.32% <100.00%> (ø)
autogpt/commands/task_statuses.py 100.00% <100.00%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

autogpt/agents/__init__.py Outdated Show resolved Hide resolved
@Pwuts Pwuts added the re-arch label Jul 13, 2023
@Pwuts Pwuts self-assigned this Jul 13, 2023
Copy link
Member

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@collijk collijk merged commit c9adedf into Significant-Gravitas:master Jul 13, 2023
@collijk collijk deleted the refactor/rename-agent-subpackage-to-agents branch July 13, 2023 14:32
@lc0rp lc0rp added this to the v0.4.5 Release milestone Jul 14, 2023
dayofthedave pushed a commit to dayofthedave/Auto-GPT that referenced this pull request Jul 17, 2023
* Add links to github issues in the README and clarify run instructions

* Rename agent subpackage to agents

* Revert all unwanted changes

* Use relative import in `agents/__init__.py`

---------

Co-authored-by: Reinier van der Leer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants