You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have RESTRICT_TO_WORKSPACE=False and I'm getting error Attempted to access absolute path '{relative_path}' in workspace '{root}'.
Changes
Only raise an error if restrict_to_root is True.
Documentation
Line 125 and 126
Test Plan
I asked Auto-GPT to add file C://text.txt with text '12345'. (in .env file RESTRICT_TO_WORKSPACE=False)
without my fix I want Auto-GPT to: add file C://text.txt with text '12345'
NOTE:All files/directories created by this agent can be found inside its workspace at: C:\Users\max\Desktop\AGI\Auto-GPT\autogpt\workspace\auto_gpt_workspace
FileAgentGPT has been created with the following details:
Name: FileAgentGPT
Role: an autonomous agent that specializes in file management and manipulation, providing efficient and reliable assistance in handling various file-related tasks.
Goals:
- Receive and process file-related commands to add, modify, or delete files as per your instructions.
- Ensure the successful addition of the specified file 'C://text.txt' with the text '12345' as requested.
- Verify the accuracy and integrity of the added file by cross-checking the content with the provided text.
- Handle any potential errors or exceptions during the file addition process and provide appropriate feedback or solutions.
- Maintain a secure and organized file system, adhering to best practices and ensuring the confidentiality and availability of your files.
Using memory of type: JSONFileMemory
Using Browser: chrome
FILEAGENTGPT THOUGHTS: To accomplish the goal of adding the specified file 'C://text.txt' with the text '12345', I will
use the 'write_to_file' command.
REASONING: The 'write_to_file' command allows me to create a new file or overwrite an existing file with the specified text content.
- Use the 'write_to_file' command with the filename 'C://text.txt' and the text '12345'.
CRITICISM: I need to ensure that the file 'C://text.txt' does not already exist before using the 'write_to_file' command to avoid overwriting any existing file.
SPEAK: I will use the 'write_to_file' command to add the file 'C://text.txt' with the text '12345'.
NEXT ACTION: COMMAND = write_to_file ARGUMENTS = {'filename': 'C://text.txt', 'text': '12345'}
Enter 'y' to authorise command, 'y -N' to run N continuous commands, 'n' to exit program, or enter feedback for FileAgentGPT...
Asking user via keyboard...
Input:y
-=-=-=-=-=-=-= COMMAND AUTHORISED BY USER -=-=-=-=-=-=-=
SYSTEM: Command write_to_file returned: Error: Attempted to access absolute path 'C:\text.txt' in workspace 'C:\Users\max\Desktop\AGI\Auto-GPT\autogpt\workspace\auto_gpt_workspace'.
with my fix I want Auto-GPT to: add file C://text.txt with text '12345'
NOTE:All files/directories created by this agent can be found inside its workspace at: C:\Users\max\Desktop\AGI\Auto-GPT\autogpt\workspace\auto_gpt_workspace
FileAgentGPT has been created with the following details:
Name: FileAgentGPT
Role: an autonomous agent that specializes in file management and manipulation, providing efficient and reliable assistance in handling various file-related tasks.
Goals:
- Receive and process file-related commands to add, modify, or delete files as per your instructions.
- Ensure the successful addition of the specified file 'C://text.txt' with the text '12345' as requested.
- Verify the accuracy and integrity of the added file by cross-checking the content with the provided text.
- Handle any potential errors or exceptions during the file addition process and provide appropriate feedback or solutions.
- Maintain a secure and organized file system, adhering to best practices and ensuring the confidentiality and availability of your files.
Using memory of type: JSONFileMemory
Using Browser: chrome
FILEAGENTGPT THOUGHTS: To accomplish the goal of adding the specified file 'C://text.txt' with the text '12345', I will
use the 'write_to_file' command.
REASONING: The 'write_to_file' command allows me to create a new file or overwrite an existing file with the specified text content.
- Use the 'write_to_file' command with the filename 'C://text.txt' and the text '12345'.
CRITICISM: I need to ensure that the file 'C://text.txt' does not already exist before using the 'write_to_file' command to avoid overwriting any existing file.
SPEAK: I will use the 'write_to_file' command to add the file 'C://text.txt' with the text '12345'.
NEXT ACTION: COMMAND = write_to_file ARGUMENTS = {'filename': 'C://text.txt', 'text': '12345'}
Enter 'y' to authorise command, 'y -N' to run N continuous commands, 'n' to exit program, or enter feedback for FileAgentGPT...
Asking user via keyboard...
Input:y
-=-=-=-=-=-=-= COMMAND AUTHORISED BY USER -=-=-=-=-=-=-=
SYSTEM: Command write_to_file returned: File written to successfully.
PR Quality Checklist
My pull request is atomic and focuses on a single change.
I have thoroughly tested my changes with multiple different prompts.
I have considered potential risks and mitigations for my changes.
I have documented my changes clearly and comprehensively.
I have not snuck in any "extra" small tweaks changes.
I have run the following commands against my code to ensure it passes our linters:
❗ Current head 7654ffb differs from pull request most recent head 4adb33b. Consider uploading reports for the commit 4adb33b to get more accurate results
Hi @antonovmaxim. Thanks for your contribution! Could you please add a test for this in your PR. Ideally the test should fail without your fix and pass with your fix. This helps us verify that we've actually solved the problem and also helps us prevent future changes from introducing this bug again.
Pwuts
changed the title
restrict_to_root fix
Allow absolute paths when not restricted to workspace root
Jul 13, 2023
Pwuts
changed the title
Allow absolute paths when not restricted to workspace root
Allow absolute paths when not restricting to workspace root
Jul 13, 2023
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pwuts
changed the title
Background
I have RESTRICT_TO_WORKSPACE=False and I'm getting error
Attempted to access absolute path '{relative_path}' in workspace '{root}'.Changes
Only raise an error if
restrict_to_rootisTrue.Documentation
Line 125 and 126
Test Plan
I asked Auto-GPT to add file C://text.txt with text '12345'. (in .env file RESTRICT_TO_WORKSPACE=False)
without my fix
I want Auto-GPT to: add file C://text.txt with text '12345' NOTE:All files/directories created by this agent can be found inside its workspace at: C:\Users\max\Desktop\AGI\Auto-GPT\autogpt\workspace\auto_gpt_workspace FileAgentGPT has been created with the following details: Name: FileAgentGPT Role: an autonomous agent that specializes in file management and manipulation, providing efficient and reliable assistance in handling various file-related tasks. Goals: - Receive and process file-related commands to add, modify, or delete files as per your instructions. - Ensure the successful addition of the specified file 'C://text.txt' with the text '12345' as requested. - Verify the accuracy and integrity of the added file by cross-checking the content with the provided text. - Handle any potential errors or exceptions during the file addition process and provide appropriate feedback or solutions. - Maintain a secure and organized file system, adhering to best practices and ensuring the confidentiality and availability of your files. Using memory of type: JSONFileMemory Using Browser: chrome FILEAGENTGPT THOUGHTS: To accomplish the goal of adding the specified file 'C://text.txt' with the text '12345', I will use the 'write_to_file' command. REASONING: The 'write_to_file' command allows me to create a new file or overwrite an existing file with the specified text content. - Use the 'write_to_file' command with the filename 'C://text.txt' and the text '12345'. CRITICISM: I need to ensure that the file 'C://text.txt' does not already exist before using the 'write_to_file' command to avoid overwriting any existing file. SPEAK: I will use the 'write_to_file' command to add the file 'C://text.txt' with the text '12345'.NEXT ACTION: COMMAND = write_to_file ARGUMENTS = {'filename': 'C://text.txt', 'text': '12345'}Enter 'y' to authorise command, 'y -N' to run N continuous commands, 'n' to exit program, or enter feedback for FileAgentGPT...
Asking user via keyboard...
Input:y
-=-=-=-=-=-=-= COMMAND AUTHORISED BY USER -=-=-=-=-=-=-=
SYSTEM: Command write_to_file returned: Error: Attempted to access absolute path 'C:\text.txt' in workspace 'C:\Users\max\Desktop\AGI\Auto-GPT\autogpt\workspace\auto_gpt_workspace'.
with my fix
I want Auto-GPT to: add file C://text.txt with text '12345' NOTE:All files/directories created by this agent can be found inside its workspace at: C:\Users\max\Desktop\AGI\Auto-GPT\autogpt\workspace\auto_gpt_workspace FileAgentGPT has been created with the following details: Name: FileAgentGPT Role: an autonomous agent that specializes in file management and manipulation, providing efficient and reliable assistance in handling various file-related tasks. Goals: - Receive and process file-related commands to add, modify, or delete files as per your instructions. - Ensure the successful addition of the specified file 'C://text.txt' with the text '12345' as requested. - Verify the accuracy and integrity of the added file by cross-checking the content with the provided text. - Handle any potential errors or exceptions during the file addition process and provide appropriate feedback or solutions. - Maintain a secure and organized file system, adhering to best practices and ensuring the confidentiality and availability of your files. Using memory of type: JSONFileMemory Using Browser: chrome FILEAGENTGPT THOUGHTS: To accomplish the goal of adding the specified file 'C://text.txt' with the text '12345', I will use the 'write_to_file' command. REASONING: The 'write_to_file' command allows me to create a new file or overwrite an existing file with the specified text content. - Use the 'write_to_file' command with the filename 'C://text.txt' and the text '12345'. CRITICISM: I need to ensure that the file 'C://text.txt' does not already exist before using the 'write_to_file' command to avoid overwriting any existing file. SPEAK: I will use the 'write_to_file' command to add the file 'C://text.txt' with the text '12345'.NEXT ACTION: COMMAND = write_to_file ARGUMENTS = {'filename': 'C://text.txt', 'text': '12345'}Enter 'y' to authorise command, 'y -N' to run N continuous commands, 'n' to exit program, or enter feedback for FileAgentGPT...
Asking user via keyboard...
Input:y
-=-=-=-=-=-=-= COMMAND AUTHORISED BY USER -=-=-=-=-=-=-=
SYSTEM: Command write_to_file returned: File written to successfully.
PR Quality Checklist