Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_browse_website #4925

Merged
merged 2 commits into from
Jul 9, 2023
Merged

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Jul 8, 2023

Background

test_browse_website sometimes breaks unnecessarily: https://github.com/Significant-Gravitas/Auto-GPT/actions/runs/5495512754/jobs/10014962625

Changes

  • Convert the result to lowercase before checking, so that "error" and "Error" don't cause a mismatch

Test Plan

CI

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@Pwuts Pwuts added this to the v0.4.5 Release milestone Jul 8, 2023
@Pwuts Pwuts added the testing label Jul 8, 2023
@github-actions github-actions bot added the size/s label Jul 8, 2023
@netlify
Copy link

netlify bot commented Jul 8, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 3c904cd
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64aac0f4e10fbb0008f81793

@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f6da992) 50.55% compared to head (3c904cd) 50.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4925   +/-   ##
=======================================
  Coverage   50.55%   50.56%           
=======================================
  Files         116      115    -1     
  Lines        4860     4790   -70     
  Branches      657      636   -21     
=======================================
- Hits         2457     2422   -35     
+ Misses       2219     2192   -27     
+ Partials      184      176    -8     
Impacted Files Coverage Δ
autogpt/agent/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@collijk collijk merged commit f6b9e86 into Significant-Gravitas:master Jul 9, 2023
@Pwuts Pwuts deleted the fix-test-browse branch July 9, 2023 16:25
Alaaelmziat pushed a commit to Alaaelmziat/Auto-GPT that referenced this pull request Jul 12, 2023
dayofthedave pushed a commit to dayofthedave/Auto-GPT that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants