Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize the configuration args #4913

Merged

Conversation

collijk
Copy link
Contributor

@collijk collijk commented Jul 7, 2023

Background

The config args are listed as a big disorganized blob. This is just some organization ahead of some logic cleanup.

Changes

  • Organize the config args into groups with headings.
  • Reduce duplication by setting the defaults on the config class.

Documentation

Headings for config groups.

Test Plan

CI. This pr has no logic changes.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • [] I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 09d72e5
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64a985ba4cf0830008f30061

@github-actions github-actions bot added the size/l label Jul 7, 2023
@collijk collijk added the code quality ⬆️ PRs that improve code quality label Jul 7, 2023
@collijk collijk added this to the v0.4.5 Release milestone Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 90.08% and project coverage change: +0.26 🎉

Comparison is base (8bce027) 50.29% compared to head (c691185) 50.56%.

❗ Current head c691185 differs from pull request most recent head 09d72e5. Consider uploading reports for the commit 09d72e5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4913      +/-   ##
==========================================
+ Coverage   50.29%   50.56%   +0.26%     
==========================================
  Files         116      116              
  Lines        4843     4861      +18     
  Branches      653      657       +4     
==========================================
+ Hits         2436     2458      +22     
+ Misses       2221     2219       -2     
+ Partials      186      184       -2     
Impacted Files Coverage Δ
autogpt/command_decorator.py 100.00% <ø> (ø)
autogpt/commands/file_operations.py 80.80% <ø> (ø)
autogpt/commands/web_search.py 97.77% <ø> (ø)
autogpt/main.py 23.68% <0.00%> (ø)
autogpt/app.py 41.86% <75.00%> (-5.20%) ⬇️
autogpt/models/command_registry.py 73.68% <82.60%> (+4.93%) ⬆️
autogpt/config/config.py 83.00% <91.17%> (+0.45%) ⬆️
autogpt/agent/agent.py 59.18% <100.00%> (ø)
autogpt/models/command.py 73.91% <100.00%> (+1.18%) ⬆️
autogpt/prompts/generator.py 92.98% <100.00%> (+6.31%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pwuts Pwuts self-assigned this Jul 8, 2023
@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@collijk collijk merged commit 59f353a into Significant-Gravitas:master Jul 8, 2023
@collijk collijk deleted the refactor/organize-config-args branch July 8, 2023 15:56
Alaaelmziat pushed a commit to Alaaelmziat/Auto-GPT that referenced this pull request Jul 12, 2023
* Organize the configuration args

* Remove duplication in setting config defaults

---------

Co-authored-by: Reinier van der Leer <[email protected]>
dayofthedave pushed a commit to dayofthedave/Auto-GPT that referenced this pull request Jul 17, 2023
* Organize the configuration args

* Remove duplication in setting config defaults

---------

Co-authored-by: Reinier van der Leer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants