Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/broken azure config #4912

Merged
merged 4 commits into from
Jul 8, 2023
Merged

Bugfix/broken azure config #4912

merged 4 commits into from
Jul 8, 2023

Conversation

collijk
Copy link
Contributor

@collijk collijk commented Jul 7, 2023

Background

We introduced a reliance on setting openai module attributes a couple of months ago to verify model access. This was causing breakages in Azure usage not fixed by #4875 or #4098.

Known Issue: We have default fallbacks when gpt4 is not available (use gpt-3.5-turbo), but azure deployments can modify the names of models and there are no guarantees that a system will have gpt3.5 if it doesn't have gpt4. I think this is mostly a non-issue as someone using azure wants their model to fail on misconfiguration as this is most likely a user error.

Changes

  • Pass in credentials when we check for model validity.
  • Put azure resolution of --gpt3only and --gpt4only on the same path.

Documentation

Test Plan

CI

Manual testing of ./run.sh with no flags, with --gpt3only flag and with --gpt4only flag on an azure instance.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit e590c1e
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64a897cd3b21fd0008a17cde

@github-actions github-actions bot added the size/m label Jul 7, 2023
@collijk
Copy link
Contributor Author

collijk commented Jul 7, 2023

@jayden5744 This should hopefully address your issues.

@collijk collijk added bug Something isn't working Azure labels Jul 7, 2023
@collijk collijk added this to the v0.4.4 Release milestone Jul 7, 2023
@lc0rp lc0rp merged commit 57315bd into master Jul 8, 2023
@lc0rp lc0rp deleted the bugfix/broken-azure-config branch July 8, 2023 02:42
dayofthedave pushed a commit to dayofthedave/Auto-GPT that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure bug Something isn't working size/m
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants