Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PLAIN_OUTPUT for normal execution #4904

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Jul 7, 2023

Background

PLAIN_OUTPUT only works when combined with a monkeypatch applied by a pytest fixture.

Changes

  • Remove the patch_emit fixture
  • Patch the output handler in Logger when config.plain_output is True

Documentation

x

Test Plan

  • Tested manually
  • CI

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit cdb85db
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64a79611bae76900083d766f

@github-actions github-actions bot added the size/m label Jul 7, 2023
@Pwuts Pwuts added this to the v0.4.5 Release milestone Jul 7, 2023
@Pwuts Pwuts force-pushed the output/fix-plain branch from 8647092 to cdb85db Compare July 7, 2023 04:35
@Pwuts Pwuts self-assigned this Jul 7, 2023
@Pwuts Pwuts merged commit 35b072f into Significant-Gravitas:master Jul 7, 2023
@Pwuts Pwuts deleted the output/fix-plain branch July 7, 2023 04:53
@lc0rp lc0rp modified the milestones: v0.4.5 Release, v0.4.4 Release Jul 8, 2023
dayofthedave pushed a commit to dayofthedave/Auto-GPT that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants