Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop AbstractSingleton as a parent class of the vector memory #4901

Conversation

collijk
Copy link
Contributor

@collijk collijk commented Jul 7, 2023

Background

Singletons are bad and we don't need them

Changes

  • Remove the abstract singleton parent class from the vector memory

Documentation

N/A

Test Plan

CI

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • [] I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit c21f14c
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64a98b830488e40008be4b02
😎 Deploy Preview https://deploy-preview-4901--auto-gpt-docs.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the size/s label Jul 7, 2023
@github-actions github-actions bot added size/m and removed size/s labels Jul 7, 2023
@github-actions github-actions bot added size/s and removed size/m labels Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (8bce027) 50.29% compared to head (97adeff) 50.20%.

❗ Current head 97adeff differs from pull request most recent head c21f14c. Consider uploading reports for the commit c21f14c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4901      +/-   ##
==========================================
- Coverage   50.29%   50.20%   -0.10%     
==========================================
  Files         116      116              
  Lines        4843     4808      -35     
  Branches      653      645       -8     
==========================================
- Hits         2436     2414      -22     
+ Misses       2221     2215       -6     
+ Partials      186      179       -7     
Impacted Files Coverage Δ
autogpt/memory/vector/providers/base.py 96.42% <100.00%> (-0.13%) ⬇️

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@collijk collijk added the re-arch label Jul 7, 2023
@collijk collijk added this to the v0.4.5 Release milestone Jul 7, 2023
@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@collijk collijk merged commit f6da992 into Significant-Gravitas:master Jul 8, 2023
@collijk collijk deleted the refactor/drop-abstract-singleton-vector-memory-parent branch July 8, 2023 16:27
Alaaelmziat pushed a commit to Alaaelmziat/Auto-GPT that referenced this pull request Jul 12, 2023
…icant-Gravitas#4901)

* Drop AbstractSingleton as a parent class of the vector memory

* Forgot pytest fixture in integration tests

* Revert typo
dayofthedave pushed a commit to dayofthedave/Auto-GPT that referenced this pull request Jul 17, 2023
…icant-Gravitas#4901)

* Drop AbstractSingleton as a parent class of the vector memory

* Forgot pytest fixture in integration tests

* Revert typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants