Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead agent manager #4900

Merged

Conversation

collijk
Copy link
Contributor

@collijk collijk commented Jul 7, 2023

Background

The AgentManager is dead code (and a confusing abstraction to begin with). It is also one of the last few singletons in the system.

Changes

  • Remove the dead AgentManager code and tests

Documentation

N/A

Test Plan

CI

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • [] I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 5918bbe
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64a997c814c8e90008c3e168

@github-actions github-actions bot added the size/l label Jul 7, 2023
@collijk collijk added the re-arch label Jul 7, 2023
@collijk collijk added this to the v0.4.5 Release milestone Jul 7, 2023
@Pwuts
Copy link
Member

Pwuts commented Jul 8, 2023

Sub-agents are still listed as an available resource in prompt_settings.yml

tests/unit/test_agent_manager.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f6da992) 50.55% compared to head (5918bbe) 50.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4900   +/-   ##
=======================================
  Coverage   50.55%   50.56%           
=======================================
  Files         116      115    -1     
  Lines        4860     4790   -70     
  Branches      657      636   -21     
=======================================
- Hits         2457     2422   -35     
+ Misses       2219     2192   -27     
+ Partials      184      176    -8     
Impacted Files Coverage Δ
autogpt/agent/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jul 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Jul 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@Pwuts Pwuts merged commit 89c1f2d into Significant-Gravitas:master Jul 8, 2023
Alaaelmziat pushed a commit to Alaaelmziat/Auto-GPT that referenced this pull request Jul 12, 2023
* Remove dead agent manager

---------

Co-authored-by: Reinier van der Leer <[email protected]>
dayofthedave pushed a commit to dayofthedave/Auto-GPT that referenced this pull request Jul 17, 2023
* Remove dead agent manager

---------

Co-authored-by: Reinier van der Leer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants