-
Notifications
You must be signed in to change notification settings - Fork 44.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix plugin loading issues #4888
Merged
Pwuts
merged 11 commits into
Significant-Gravitas:master
from
Pwuts:plugins/fix-loading-and-init
Jul 5, 2023
Merged
Fix plugin loading issues #4888
Pwuts
merged 11 commits into
Significant-Gravitas:master
from
Pwuts:plugins/fix-loading-and-init
Jul 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for auto-gpt-docs canceled.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4888 +/- ##
==========================================
+ Coverage 49.90% 50.05% +0.14%
==========================================
Files 116 116
Lines 4813 4799 -14
Branches 649 643 -6
==========================================
Hits 2402 2402
+ Misses 2226 2218 -8
+ Partials 185 179 -6
☔ View full report in Codecov by Sentry. |
collijk
reviewed
Jul 5, 2023
Pwuts
force-pushed
the
plugins/fix-loading-and-init
branch
from
July 5, 2023 19:37
24125dd
to
c1beebd
Compare
Inject required args only into plugins config
collijk
approved these changes
Jul 5, 2023
dayofthedave
pushed a commit
to dayofthedave/Auto-GPT
that referenced
this pull request
Jul 17, 2023
* Fix Config model initialization * Fix basedir determination in install_plugin_dependencies * Add logging to install_plugin_dependencies() --------- Co-authored-by: collijk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
ALLOWLISTED_PLUGINS
andDENYLISTED_PLUGINS
do not currently work, becauseConfig
is initialized (and therewith an emptyplugins_config.yaml
is created) before those config variables are loaded from .env.--install-plugin-deps
can fail, becauseinstall_plugin_dependencies()
assumes that the first named item in an archive is the base folder, which it isn't always.Changes
config.model_post_init()
at the end ofConfigurable.build_agent_configuration
instead of inConfig.__init__
, to make sure.env
has been loaded before proceeding to model init (includingPluginsConfig.load_config(config)
)install_plugin_dependencies()
install_plugin_dependencies()
looks for requirements files in zipped pluginsDocumentation
Test Plan
PR Quality Checklist